Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 251603004: Remove NOTIFICATION_EXTENSION_LOADED_DEPRECATED from c/b/ui/extensions (Closed)

Created:
6 years, 8 months ago by limasdf
Modified:
6 years, 7 months ago
Reviewers:
Finnur, benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove NOTIFICATION_EXTENSION_LOADED_DEPRECATED from c/b/ui/extensions BUG=354046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270070

Patch Set 1 : #

Total comments: 2

Patch Set 2 : address review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -53 lines) Patch
M chrome/browser/ui/extensions/extension_enable_flow.h View 1 5 chunks +18 lines, -1 line 0 comments Download
M chrome/browser/ui/extensions/extension_enable_flow.cc View 5 chunks +13 lines, -15 lines 0 comments Download
M chrome/browser/ui/extensions/extension_installed_bubble.h View 4 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/ui/extensions/extension_installed_bubble.cc View 1 4 chunks +34 lines, -36 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
limasdf
@miket, how are you? :) I'm cleaning NOTIFICATION_EXTENSION_LOADED_DEPRECATED. Please take a look when you have ...
6 years, 8 months ago (2014-04-25 16:15:00 UTC) #1
limasdf
Added benwells as reviewer. Please take a look.
6 years, 7 months ago (2014-05-11 11:15:53 UTC) #2
miket_OOO
On 2014/05/11 11:15:53, sunglim wrote: > Added benwells as reviewer. > Please take a look. ...
6 years, 7 months ago (2014-05-12 21:00:26 UTC) #3
benwells
lgtm with the namespace added. https://codereview.chromium.org/251603004/diff/20001/chrome/browser/ui/extensions/extension_enable_flow.h File chrome/browser/ui/extensions/extension_enable_flow.h (right): https://codereview.chromium.org/251603004/diff/20001/chrome/browser/ui/extensions/extension_enable_flow.h#newcode120 chrome/browser/ui/extensions/extension_enable_flow.h:120: ScopedObserver<extensions::ExtensionRegistry, ExtensionRegistryObserver> You should ...
6 years, 7 months ago (2014-05-13 01:40:50 UTC) #4
limasdf
Thanks for the review! https://codereview.chromium.org/251603004/diff/20001/chrome/browser/ui/extensions/extension_enable_flow.h File chrome/browser/ui/extensions/extension_enable_flow.h (right): https://codereview.chromium.org/251603004/diff/20001/chrome/browser/ui/extensions/extension_enable_flow.h#newcode120 chrome/browser/ui/extensions/extension_enable_flow.h:120: ScopedObserver<extensions::ExtensionRegistry, ExtensionRegistryObserver> On 2014/05/13 01:40:50, ...
6 years, 7 months ago (2014-05-13 06:19:27 UTC) #5
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 7 months ago (2014-05-13 06:19:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/251603004/60001
6 years, 7 months ago (2014-05-13 06:19:46 UTC) #7
Finnur
Ben already LG'ed but this also LGTM.
6 years, 7 months ago (2014-05-13 11:10:31 UTC) #8
commit-bot: I haz the power
Change committed as 270070
6 years, 7 months ago (2014-05-13 11:49:32 UTC) #9
limasdf
6 years, 7 months ago (2014-05-13 14:44:06 UTC) #10
Message was sent while issue was closed. 
On 2014/05/13 11:49:32, I haz the power (commit-bot) wrote:
> Change committed as 270070

Thanks for the review! Ben and Finnur!

Powered by Google App Engine
This is Rietveld 408576698