Remove NOTIFICATION_EXTENSION_LOADED_DEPRECATED from c/b/ui/extensions

chrome/browser/ui/extensions/extension_enable_flow.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_ENABLE_FLOW_H_
 #define CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_ENABLE_FLOW_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
+#include "base/scoped_observer.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/page_navigator.h"
+#include "extensions/browser/extension_registry_observer.h"
 
 class ExtensionEnableFlowDelegate;
 
 namespace content {
 class PageNavigator;
 class WebContents;
 }
 
+namespace extensions {
+class ExtensionRegistry;
+}
+
 // ExtensionEnableFlow performs an UI flow to enable a disabled/terminated
 // extension. It calls its delegate when enabling is done or is aborted.
 // Callback on the delegate might be called synchronously if there is no
 // permission change while the extension is disabled/terminated (or the
 // extension is enabled already). Otherwise, a re-enable install prompt is
 // shown to user. The extension is enabled when user acknowledges it or the
 // flow is aborted when user declines it.
 class ExtensionEnableFlow : public ExtensionInstallPrompt::Delegate,
                             public content::PageNavigator,
-                            public content::NotificationObserver {
+                            public content::NotificationObserver,
+                            public extensions::ExtensionRegistryObserver {
  public:
   ExtensionEnableFlow(Profile* profile,
                       const std::string& extension_id,
                       ExtensionEnableFlowDelegate* delegate);
   virtual ~ExtensionEnableFlow();
 
   // Starts the flow and the logic continues on |delegate_| after enabling is
   // finished or aborted. Note that |delegate_| could be called synchronously
   // before this call returns when there is no need to show UI to finish the
   // enabling flow. Three variations of the flow are supported:
@@ skipping 25 matching lines @@
 
   // Starts/stops observing extension load notifications.
   void StartObserving();
   void StopObserving();
 
   // content::NotificationObserver overrides:
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
+  // extensions::ExtensionRegistryObserver overrides:
+  virtual void OnExtensionLoaded(
+      content::BrowserContext* browser_context,
+      const extensions::Extension* extension) OVERRIDE;
+
   // ExtensionInstallPrompt::Delegate overrides:
   virtual void InstallUIProceed() OVERRIDE;
   virtual void InstallUIAbort(bool user_initiated) OVERRIDE;
 
   // content::PageNavigator overrides:
   virtual content::WebContents* OpenURL(
       const content::OpenURLParams& params) OVERRIDE;
 
   Profile* const profile_;
   const std::string extension_id_;
   ExtensionEnableFlowDelegate* const delegate_;  // Not owned.
 
   // Parent web contents for ExtensionInstallPrompt that may be created during
   // the flow. Note this is mutually exclusive with |parent_window_| below.
   content::WebContents* parent_contents_;
 
   // Parent native window for ExtensionInstallPrompt. Note this is mutually
   // exclusive with |parent_contents_| above.
   gfx::NativeWindow parent_window_;
 
   // Called to acquire a parent window for the prompt. This is used for clients
   // who only want to create a window if it is required.
   base::Callback<gfx::NativeWindow(void)> window_getter_;
 
   scoped_ptr<ExtensionInstallPrompt> prompt_;
   content::NotificationRegistrar registrar_;
 
+  // Listen to extension load notification.
+  ScopedObserver<extensions::ExtensionRegistry, ExtensionRegistryObserver>

[benwells, 2014/05/13 01:40:50]

You should have extensions::ExtensionRegistryObserver. This does seem to compile
without it, on windows anyway, but let's not rely on it.

[limasdf, 2014/05/13 06:19:27]

Done.

+      extension_registry_observer_;
+
   DISALLOW_COPY_AND_ASSIGN(ExtensionEnableFlow);
 };
 
 #endif  // CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_ENABLE_FLOW_H_