Issue 251583005: Add a test that JSGlobalProxy properly causes Object.observe to trigger access check callbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 251583005: Add a test that JSGlobalProxy properly causes Object.observe to trigger access check callbacks (Closed)

Created:
6 years, 7 months ago by adamk

Modified:
6 years, 7 months ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add a test that JSGlobalProxy properly causes Object.observe to trigger access check callbacks Note that this is mainly for demonstration purposes, as after the attached bug is fixed Object.observe should no longer be calling into the embedder for access checks. R=dcarney@chromium.org BUG=367817

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -0 lines)			Patch
	M	test/cctest/test-object-observe.cc	View		1 chunk	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adamk

6 years, 7 months ago (2014-04-30 20:09:09 UTC) #3

On 2014/04/29 06:24:22, dcarney wrote:
> lgtm

This test is obsoleted by rafaelw's patch
https://codereview.chromium.org/265503002/

Expand Messages | Collapse Messages