Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1443)

Issue 2515793002: Prevent in-page navigations from stopping the app banner pipeline. (Closed)

Created:
4 years, 1 month ago by dominickn
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Prevent in-page navigations from stopping the app banner pipeline. Triggering a fragment navigation or history.pushState action whilst the app banner pipeline is checking a page's eligibility will prevent the banner from being shown even if the page is eligible. This is because any main frame navigation currently stops the checking pipeline to prevent the banner from being shown after a navigation. This CL addresses the issue by ignoring in-page navigations when the banner pipeline is active. BUG=666165 Review-Url: https://codereview.chromium.org/2507163003 Cr-Commit-Position: refs/heads/master@{#432778} (cherry picked from commit 803300091bf7d275a9456b0362e3a9ddb9f61abb) Committed: https://chromium.googlesource.com/chromium/src/+/65fc2a2547f3ce03aedf8bedbbec685029a76c2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/banners/app_banner_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dominickn
4 years, 1 month ago (2016-11-18 19:02:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
65fc2a2547f3ce03aedf8bedbbec685029a76c2c.

Powered by Google App Engine
This is Rietveld 408576698