Chromium Code Reviews
DescriptionPrevent in-page navigations from stopping the app banner pipeline.
Triggering a fragment navigation or history.pushState action whilst the
app banner pipeline is checking a page's eligibility will prevent the
banner from being shown even if the page is eligible. This is because
any main frame navigation currently stops the checking pipeline to
prevent the banner from being shown after a navigation.
This CL addresses the issue by ignoring in-page navigations when the
banner pipeline is active.
BUG=666165
Review-Url: https://codereview.chromium.org/2507163003
Cr-Commit-Position: refs/heads/master@{#432778}
(cherry picked from commit 803300091bf7d275a9456b0362e3a9ddb9f61abb)
Committed: https://chromium.googlesource.com/chromium/src/+/65fc2a2547f3ce03aedf8bedbbec685029a76c2c
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||