Prevent in-page navigations from stopping the app banner pipeline.

Prevent in-page navigations from stopping the app banner pipeline.

Triggering a fragment navigation or history.pushState action whilst the
app banner pipeline is checking a page's eligibility will prevent the
banner from being shown even if the page is eligible. This is because
any main frame navigation currently stops the checking pipeline to
prevent the banner from being shown after a navigation.

This CL addresses the issue by ignoring in-page navigations when the
banner pipeline is active.

BUG=666165
Committed: https://crrev.com/803300091bf7d275a9456b0362e3a9ddb9f61abb
Cr-Commit-Position: refs/heads/master@{#432778}

[dominickn, 2016-11-17 02:42:37]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[dominickn, 2016-11-17 02:43:06]

dominickn@chromium.org changed reviewers:
+ benwells@chromium.org

[dominickn, 2016-11-17 02:43:07]

PTAL thanks!

[commit-bot: I haz the power, 2016-11-17 02:44:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[benwells, 2016-11-17 02:55:02]

lgtm

[commit-bot: I haz the power, 2016-11-17 05:33:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 05:33:43]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-11-17 05:56:14]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2016-11-17 05:56:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 06:03:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-17 06:06:43]

Description was changed from

==========
Prevent in-page navigations from stopping the app banner pipeline.

Triggering a fragment navigation or history.pushState action whilst the
app banner pipeline is checking a page's eligibility will prevent the
banner from being shown even if the page is eligible. This is because
any main frame navigation currently stops the checking pipeline to
prevent the banner from being shown after a navigation.

This CL addresses the issue by ignoring in-page navigations when the
banner pipeline is active.

BUG=666165
==========

to

==========
Prevent in-page navigations from stopping the app banner pipeline.

Triggering a fragment navigation or history.pushState action whilst the
app banner pipeline is checking a page's eligibility will prevent the
banner from being shown even if the page is eligible. This is because
any main frame navigation currently stops the checking pipeline to
prevent the banner from being shown after a navigation.

This CL addresses the issue by ignoring in-page navigations when the
banner pipeline is active.

BUG=666165

Committed: https://crrev.com/803300091bf7d275a9456b0362e3a9ddb9f61abb
Cr-Commit-Position: refs/heads/master@{#432778}
==========

[commit-bot: I haz the power, 2016-11-17 06:06:44]

Patchset 1 (id:??) landed as
https://crrev.com/803300091bf7d275a9456b0362e3a9ddb9f61abb
Cr-Commit-Position: refs/heads/master@{#432778}