Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2515653003: Deprecate legacy callers for HTMLEmbedElement and HTMLObjectElement (Closed)

Created:
4 years, 1 month ago by foolip
Modified:
4 years, 1 month ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate legacy callers for HTMLEmbedElement and HTMLObjectElement Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/AiDZ7ru9mGg/_D_9Fcc2AwAJ BUG=663662 Committed: https://crrev.com/0993fff22319c9a7f24bdf3bfcf4db1d8521a260 Cr-Commit-Position: refs/heads/master@{#433224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
foolip
PTAL and CQ
4 years, 1 month ago (2016-11-18 16:09:29 UTC) #6
Rick Byers
lgtm
4 years, 1 month ago (2016-11-18 16:45:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515653003/1
4 years, 1 month ago (2016-11-18 16:46:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 17:08:02 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 17:11:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0993fff22319c9a7f24bdf3bfcf4db1d8521a260
Cr-Commit-Position: refs/heads/master@{#433224}

Powered by Google App Engine
This is Rietveld 408576698