Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

Issue 2515653003: Deprecate legacy callers for HTMLEmbedElement and HTMLObjectElement (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/Deprecation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp
index 0e929fa81ad58532fb87e0ada498f6593c640883..1ecd97782609ac828f6d3fe857bb1a055931053c 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp
@@ -33,6 +33,7 @@
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8HTMLEmbedElement.h"
#include "bindings/core/v8/V8HTMLObjectElement.h"
+#include "core/frame/Deprecation.h"
#include "core/frame/UseCounter.h"
#include "wtf/PtrUtil.h"
#include <memory>
@@ -162,16 +163,16 @@ void invokeOnScriptableObject(const v8::FunctionCallbackInfo<v8::Value>& info) {
void V8HTMLEmbedElement::legacyCallCustom(
const v8::FunctionCallbackInfo<v8::Value>& info) {
invokeOnScriptableObject<V8HTMLEmbedElement>(info);
- UseCounter::countIfNotPrivateScript(
- info.GetIsolate(), V8HTMLEmbedElement::toImpl(info.Holder())->document(),
+ Deprecation::countDeprecationIfNotPrivateScript(
+ info.GetIsolate(), currentExecutionContext(info.GetIsolate()),
UseCounter::HTMLEmbedElementLegacyCall);
}
void V8HTMLObjectElement::legacyCallCustom(
const v8::FunctionCallbackInfo<v8::Value>& info) {
invokeOnScriptableObject<V8HTMLObjectElement>(info);
- UseCounter::countIfNotPrivateScript(
- info.GetIsolate(), V8HTMLObjectElement::toImpl(info.Holder())->document(),
+ Deprecation::countDeprecationIfNotPrivateScript(
+ info.GetIsolate(), currentExecutionContext(info.GetIsolate()),
UseCounter::HTMLObjectElementLegacyCall);
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/Deprecation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698