Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2515613002: deprecate FLAGS_quic_disable_pre_34 (Closed)

Created:
4 years, 1 month ago by mpw
Modified:
4 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

deprecate FLAGS_quic_disable_pre_34 Removes support for QUIC v32 and v33 which means: * Strike Registers are dead! * Entropy is dead! * ACKs never contain missing packets * Diversification nonces are always present in SHLOs Merge internal change: 138716334 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+547 lines, -5109 lines) Patch
M net/net.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_connection_logger.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_connection_logger.cc View 3 chunks +1 line, -50 lines 0 comments Download
M net/quic/chromium/quic_http_stream.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/core/congestion_control/general_loss_algorithm_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/crypto/crypto_server_test.cc View 3 chunks +9 lines, -34 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.cc View 2 chunks +5 lines, -12 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 3 chunks +8 lines, -84 lines 0 comments Download
M net/quic/core/quic_connection.h View 3 chunks +0 lines, -6 lines 0 comments Download
M net/quic/core/quic_connection.cc View 14 chunks +7 lines, -87 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 51 chunks +87 lines, -307 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_crypto_server_stream.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream_test.cc View 5 chunks +3 lines, -100 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/core/quic_framer.h View 10 chunks +2 lines, -66 lines 0 comments Download
M net/quic/core/quic_framer.cc View 22 chunks +11 lines, -387 lines 0 comments Download
M net/quic/core/quic_framer_test.cc View 152 chunks +263 lines, -2513 lines 0 comments Download
M net/quic/core/quic_multipath_sent_packet_manager_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/quic/core/quic_packet_creator.h View 6 chunks +1 line, -33 lines 0 comments Download
M net/quic/core/quic_packet_creator.cc View 8 chunks +1 line, -24 lines 0 comments Download
M net/quic/core/quic_packet_creator_test.cc View 5 chunks +0 lines, -116 lines 0 comments Download
M net/quic/core/quic_packet_generator.h View 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/core/quic_packet_generator.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/core/quic_packet_generator_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/quic_protocol.h View 7 chunks +0 lines, -27 lines 0 comments Download
M net/quic/core/quic_protocol.cc View 11 chunks +12 lines, -39 lines 0 comments Download
M net/quic/core/quic_protocol_test.cc View 14 chunks +18 lines, -55 lines 0 comments Download
M net/quic/core/quic_received_packet_manager.h View 5 chunks +3 lines, -90 lines 0 comments Download
M net/quic/core/quic_received_packet_manager.cc View 8 chunks +1 line, -156 lines 0 comments Download
M net/quic/core/quic_received_packet_manager_test.cc View 4 chunks +6 lines, -267 lines 0 comments Download
D net/quic/core/quic_sent_entropy_manager.h View 1 chunk +0 lines, -89 lines 0 comments Download
D net/quic/core/quic_sent_entropy_manager.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D net/quic/core/quic_sent_entropy_manager_test.cc View 1 chunk +0 lines, -96 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager_test.cc View 58 chunks +63 lines, -94 lines 0 comments Download
M net/quic/core/quic_types.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_unacked_packet_map_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_versions.h View 2 chunks +1 line, -4 lines 0 comments Download
M net/quic/core/quic_versions.cc View 3 chunks +1 line, -11 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 2 chunks +0 lines, -15 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M net/quic/test_tools/quic_received_packet_manager_peer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/quic/test_tools/quic_received_packet_manager_peer.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 9 chunks +4 lines, -16 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 2 chunks +2 lines, -32 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 6 chunks +5 lines, -45 lines 0 comments Download
M net/tools/quic/chlo_extractor_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 5 chunks +13 lines, -44 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/tools/quic/quic_packet_printer_bin.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/tools/quic/stateless_rejector.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/stateless_rejector_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 2508393002 Patch 1

Dependent Patchsets:

Issue 2512063003 Patch 1

Messages

Total messages: 2 (0 generated)
mpw
4 years, 1 month ago (2016-11-18 06:32:59 UTC) #1
Ryan Hamilton
4 years, 1 month ago (2016-11-18 15:09:53 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698