Issue 2512063003: Move QuicIoVector into its own header file. No behavior change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2512063003: Move QuicIoVector into its own header file. No behavior change. (Closed)

Created:
4 years, 1 month ago by mpw

Modified:
4 years, 1 month ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move QuicIoVector into its own header file. No behavior change. Also #includes build_config.h from net/base/iovec.h, to fix an implicit include order dependency uncovered by this change. Merge internal change: 138765876 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -11 lines)			Patch
M	net/base/iovec.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/net.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	net/quic/core/quic_iovector.h	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_packet_creator.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/core/quic_protocol.h	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	net/quic/core/quic_stream.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/core/quic_utils.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_packet_creator_peer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2515613002 Patch 1

Dependent Patchsets:

Issue 2517603003 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages