Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: media/base/mime_util_unittest.cc

Issue 2515553002: Fix mimetype mappings for FLAC support. (Closed)
Patch Set: Fix test deletion during merge. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/mime_util_unittest.cc
diff --git a/media/base/mime_util_unittest.cc b/media/base/mime_util_unittest.cc
index dd226f6320a550233ad5a337ad554d07062a3c62..87eb90497baa6c22430c870162d02b0fdbd04754 100644
--- a/media/base/mime_util_unittest.cc
+++ b/media/base/mime_util_unittest.cc
@@ -124,6 +124,8 @@ TEST(MimeUtilTest, CommonMediaMimeType) {
EXPECT_TRUE(IsSupportedMediaMimeType("audio/wav"));
EXPECT_TRUE(IsSupportedMediaMimeType("audio/x-wav"));
+ EXPECT_TRUE(IsSupportedMediaMimeType("audio/flac"));
+
EXPECT_TRUE(IsSupportedMediaMimeType("audio/ogg"));
EXPECT_TRUE(IsSupportedMediaMimeType("application/ogg"));
#if defined(OS_ANDROID)
@@ -260,6 +262,7 @@ TEST(IsCodecSupportedOnPlatformTest, EncryptedCodecBehavior) {
break;
// These codecs are always available with platform decoder support.
+ case MimeUtil::FLAC:
ddorwin 2016/11/18 00:11:21 ditto
DaleCurtis 2016/11/18 00:39:26 Done.
case MimeUtil::PCM:
case MimeUtil::MP3:
case MimeUtil::MPEG4_AAC:
@@ -314,6 +317,7 @@ TEST(IsCodecSupportedOnPlatformTest, ClearCodecBehaviorWithAndroidPipeline) {
break;
// These codecs are always available via MediaPlayer.
+ case MimeUtil::FLAC:
case MimeUtil::PCM:
case MimeUtil::MP3:
case MimeUtil::MPEG4_AAC:
@@ -374,6 +378,7 @@ TEST(IsCodecSupportedOnPlatformTest, ClearCodecBehaviorWithUnifiedPipeline) {
break;
// These codecs are always supported with the unified pipeline.
+ case MimeUtil::FLAC:
case MimeUtil::PCM:
case MimeUtil::MPEG2_AAC:
case MimeUtil::MP3:

Powered by Google App Engine
This is Rietveld 408576698