Fix mimetype mappings for FLAC support.

Fix mimetype mappings for FLAC support.

FLAC support landed with the ffmpeg update in M56, we should
ensure our mimetypes are correct in this case.

Patch from servolk@ https://codereview.chromium.org/2362193003

BUG=93887
Committed: https://crrev.com/97bfa47d1fc314ca4ce969d941d142749880268f
Cr-Commit-Position: refs/heads/master@{#433125}

[DaleCurtis, 2016-11-17 23:42:08]

dalecurtis@chromium.org changed reviewers:
+ ddorwin@chromium.org, wolenetz@chromium.org

[ddorwin, 2016-11-18 00:11:21]

LGTM. Thanks. Very tiny issues, except we're missing a test for 'audio/x-flac'.

https://codereview.chromium.org/2515553002/diff/20001/content/browser/media/m...
File content/browser/media/media_canplaytype_browsertest.cc (right):

https://codereview.chromium.org/2515553002/diff/20001/content/browser/media/m...
content/browser/media/media_canplaytype_browsertest.cc:632: EXPECT_EQ(kNot,
CanPlay("'video/flac'"));
nit: I'd move these up and note that only "audio/flac" is supported.

https://codereview.chromium.org/2515553002/diff/20001/content/browser/media/m...
content/browser/media/media_canplaytype_browsertest.cc:635: EXPECT_EQ(kNot,
CanPlay("'audio/flac; codecs=\"flac\"'"));
'audio/x-flac' is not tested.

https://codereview.chromium.org/2515553002/diff/20001/media/base/mime_util_in...
File media/base/mime_util_internal.cc (right):

https://codereview.chromium.org/2515553002/diff/20001/media/base/mime_util_in...
media/base/mime_util_internal.cc:566: case FLAC:
Pedantic: This should be after MPEG4_AAC. The others are consistent I think.

https://codereview.chromium.org/2515553002/diff/20001/media/base/mime_util_in...
media/base/mime_util_internal.cc:771: case FLAC:
Pedantic: This should be after OPUS.

https://codereview.chromium.org/2515553002/diff/20001/media/base/mime_util_in...
media/base/mime_util_internal.cc:781: return true;
Should we have a NOTREACHED() here?
Can be a separate CL.

https://codereview.chromium.org/2515553002/diff/20001/media/base/mime_util_un...
File media/base/mime_util_unittest.cc (right):

https://codereview.chromium.org/2515553002/diff/20001/media/base/mime_util_un...
media/base/mime_util_unittest.cc:265: case MimeUtil::FLAC:
ditto

[DaleCurtis, 2016-11-18 00:39:19]

Description was changed from

==========
Add FLAC audio codec support.

Patch from servolk@ https://codereview.chromium.org/2362193003

BUG=93887
==========

to

==========
Fix mimetype mappings for FLAC support.

FLAC support landed with the ffmpeg update in M56, we should
ensure our mimetypes are correct in this case.

Patch from servolk@ https://codereview.chromium.org/2362193003

BUG=93887
==========

[DaleCurtis, 2016-11-18 00:39:26]

https://codereview.chromium.org/2515553002/diff/20001/content/browser/media/m...
File content/browser/media/media_canplaytype_browsertest.cc (right):

https://codereview.chromium.org/2515553002/diff/20001/content/browser/media/m...
content/browser/media/media_canplaytype_browsertest.cc:632: EXPECT_EQ(kNot,
CanPlay("'video/flac'"));
On 2016/11/18 at 00:11:21, ddorwin wrote:
> nit: I'd move these up and note that only "audio/flac" is supported.

Done.

https://codereview.chromium.org/2515553002/diff/20001/content/browser/media/m...
content/browser/media/media_canplaytype_browsertest.cc:635: EXPECT_EQ(kNot,
CanPlay("'audio/flac; codecs=\"flac\"'"));
On 2016/11/18 at 00:11:21, ddorwin wrote:
> 'audio/x-flac' is not tested.

Done.

https://codereview.chromium.org/2515553002/diff/20001/media/base/mime_util_in...
File media/base/mime_util_internal.cc (right):

https://codereview.chromium.org/2515553002/diff/20001/media/base/mime_util_in...
media/base/mime_util_internal.cc:566: case FLAC:
On 2016/11/18 at 00:11:21, ddorwin wrote:
> Pedantic: This should be after MPEG4_AAC. The others are consistent I think.

Done.

https://codereview.chromium.org/2515553002/diff/20001/media/base/mime_util_in...
media/base/mime_util_internal.cc:771: case FLAC:
On 2016/11/18 at 00:11:21, ddorwin wrote:
> Pedantic: This should be after OPUS.

Done.

https://codereview.chromium.org/2515553002/diff/20001/media/base/mime_util_un...
File media/base/mime_util_unittest.cc (right):

https://codereview.chromium.org/2515553002/diff/20001/media/base/mime_util_un...
media/base/mime_util_unittest.cc:265: case MimeUtil::FLAC:
On 2016/11/18 at 00:11:21, ddorwin wrote:
> ditto

Done.

[wolenetz, 2016-11-18 00:57:05]

lgtm

[DaleCurtis, 2016-11-18 01:18:26]

Looks like mkv+flac works in ffmpeg too, but we don't need to advertise support
for that yet, since technically we only support webm+opus|vorbis.

[DaleCurtis, 2016-11-18 03:58:20]

The CQ bit was checked by dalecurtis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 03:59:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 05:20:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 05:20:55]

Dry run: This issue passed the CQ dry run.

[DaleCurtis, 2016-11-18 05:47:26]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2016-11-18 05:47:27]

The patchset sent to the CQ was uploaded after l-g-t-m from ddorwin@chromium.org
Link to the patchset: https://codereview.chromium.org/2515553002/#ps40001
(title: "Comments.")

[commit-bot: I haz the power, 2016-11-18 05:47:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 05:52:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-18 05:55:52]

Description was changed from

==========
Fix mimetype mappings for FLAC support.

FLAC support landed with the ffmpeg update in M56, we should
ensure our mimetypes are correct in this case.

Patch from servolk@ https://codereview.chromium.org/2362193003

BUG=93887
==========

to

==========
Fix mimetype mappings for FLAC support.

FLAC support landed with the ffmpeg update in M56, we should
ensure our mimetypes are correct in this case.

Patch from servolk@ https://codereview.chromium.org/2362193003

BUG=93887

Committed: https://crrev.com/97bfa47d1fc314ca4ce969d941d142749880268f
Cr-Commit-Position: refs/heads/master@{#433125}
==========

[commit-bot: I haz the power, 2016-11-18 05:55:53]

Patchset 3 (id:??) landed as
https://crrev.com/97bfa47d1fc314ca4ce969d941d142749880268f
Cr-Commit-Position: refs/heads/master@{#433125}