Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2515413002: Revert workaround due to perf regression (Closed)

Created:
4 years, 1 month ago by Kai Ninomiya
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, haraken, dglazkov+blink, darin-cc_chromium.org, blink-reviews, piman+watch_chromium.org, kinuko+watch, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert workaround due to perf regression Revert "Work around unknown Mac Intel driver bug causing non-deterministic behavior in GPU readback from 2D canvas" ( https://crrev.com/2503283007 ) Revert "clarify description for force_software_readback_from_2d_canvas" ( https://crrev.com/2505363004 ) BUG=667352, 665656 TBR=kbr@chromium.org,esprehn@chromium.org,piman@chromium.org,zmo@chromium.org,tsepez@chromium.org,ben@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/04a4e99b99f399411837ebe3489e9e2b2bd96685 Cr-Commit-Position: refs/heads/master@{#433704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -41 lines) Patch
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 chunk +27 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +1 line, -13 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.in View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +3 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
Kai Ninomiya
PTAL
4 years, 1 month ago (2016-11-21 20:51:31 UTC) #8
Ken Russell (switch to Gerrit)
lgtm
4 years, 1 month ago (2016-11-21 20:55:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515413002/1
4 years, 1 month ago (2016-11-21 20:56:07 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_optional_gpu_tests_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_optional_gpu_tests_rel/builds/1093)
4 years, 1 month ago (2016-11-21 22:30:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515413002/1
4 years, 1 month ago (2016-11-21 22:39:01 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 23:56:00 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 23:59:38 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04a4e99b99f399411837ebe3489e9e2b2bd96685
Cr-Commit-Position: refs/heads/master@{#433704}

Powered by Google App Engine
This is Rietveld 408576698