Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2515383004: Revert of Send encoded_body_length to renderer when response completed (1/3) (Closed)

Created:
4 years ago by Maria
Modified:
4 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, loading-reviews_chromium.org, darin (slow to review), mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Send encoded_body_length to renderer when response completed (1/3) (patchset #4 id:60001 of https://codereview.chromium.org/2514713002/ ) Reason for revert: I believe this change broke cronet tests: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Marshmallow%2064bit%20Perf/builds/3490 Original issue's description: > Send encoded_body_length to renderer when response completed (1/3) > > Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived > IPC message. With this series of CLs, it will be dispatched when a resource > loading is completed. This is needed to use mojo data pipe for transferring > the response body. > > - 1/3: https://codereview.chromium.org/2514713002/ > - 2/3: https://codereview.chromium.org/2510333002/ > - 3/3: https://codereview.chromium.org/2506363005/ > > Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaGFQ/edit# > > This CL adds "encoded_body_length" property to ResourceRequestCompletionStatus. > This CL doesn't change the behavior. > > BUG=666216 > > Committed: https://crrev.com/1033246a67ce26d0150242a071e61330be318433 > Cr-Commit-Position: refs/heads/master@{#434032} TBR=ricea@chromium.org,tzik@chromium.org,rdsmith@chromium.org,tsepez@chromium.org,yhirano@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=666216 Committed: https://crrev.com/b1bc4b42b14c2f238186b04920a504dc8bb41d2d Cr-Commit-Position: refs/heads/master@{#434064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -94 lines) Patch
M content/browser/loader/async_resource_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/async_resource_handler_unittest.cc View 6 chunks +7 lines, -43 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/url_loader_factory_impl_unittest.cc View 3 chunks +0 lines, -34 lines 0 comments Download
M content/common/resource_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/resource_request_completion_status.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/test/url_request/url_request_failed_job.h View 2 chunks +0 lines, -2 lines 0 comments Download
M net/test/url_request/url_request_failed_job.cc View 3 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Maria
Created Revert of Send encoded_body_length to renderer when response completed (1/3)
4 years ago (2016-11-23 01:04:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515383004/1
4 years ago (2016-11-23 01:05:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 01:17:34 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-23 01:19:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1bc4b42b14c2f238186b04920a504dc8bb41d2d
Cr-Commit-Position: refs/heads/master@{#434064}

Powered by Google App Engine
This is Rietveld 408576698