Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2506363005:
Send encoded_body_length to renderer when response completed (3/3) (Closed)
DescriptionSend encoded_body_length to renderer when response completed (3/3)
Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.
- 1/3: https://codereview.chromium.org/2514713002/
- 2/3: https://codereview.chromium.org/2510333002/
- 3/3: https://codereview.chromium.org/2506363005/
Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaGFQ/edit#
This CL drops encoded_body_length field from ResourceMsg_DataReceived and
ResourceMsg_InlinedDataChunkReceived. This CL doesn't change the behavior.
BUG=666216
Committed: https://crrev.com/ce1c7996be64c3af7243256c5032f11aef6fe7cd
Cr-Commit-Position: refs/heads/master@{#434684}
Patch Set 1 : fix #
Total comments: 1
Patch Set 2 : fix #Patch Set 3 : rebase #
Depends on Patchset: Messages
Total messages: 46 (37 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Dispatch encoded_body_size at the completion timing (3/3) BUG=666216 ========== to ========== Dispatch encoded_body_length at the completion timing (3/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. This CL drops encoded_body_length field from ResourceMsg_DataReceived and ResourceMsg_InlinedDataChunkReceived. This CL doesn't change the behavior. BUG=666216 ==========
yhirano@chromium.org changed reviewers: + ricea@chromium.org, tzik@chromium.org
Description was changed from ========== Dispatch encoded_body_length at the completion timing (3/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. This CL drops encoded_body_length field from ResourceMsg_DataReceived and ResourceMsg_InlinedDataChunkReceived. This CL doesn't change the behavior. BUG=666216 ========== to ========== Dispatch encoded_body_length at the completion timing (3/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ This CL drops encoded_body_length field from ResourceMsg_DataReceived and ResourceMsg_InlinedDataChunkReceived. This CL doesn't change the behavior. BUG=666216 ==========
Description was changed from ========== Dispatch encoded_body_length at the completion timing (3/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ This CL drops encoded_body_length field from ResourceMsg_DataReceived and ResourceMsg_InlinedDataChunkReceived. This CL doesn't change the behavior. BUG=666216 ========== to ========== Send encoded_body_length to renderer when response completed (3/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ This CL drops encoded_body_length field from ResourceMsg_DataReceived and ResourceMsg_InlinedDataChunkReceived. This CL doesn't change the behavior. BUG=666216 ==========
lgtm https://codereview.chromium.org/2506363005/diff/40001/content/browser/loader/... File content/browser/loader/async_resource_handler.cc (right): https://codereview.chromium.org/2506363005/diff/40001/content/browser/loader/... content/browser/loader/async_resource_handler.cc:558: return TrackDifference(request()->GetTotalReceivedBytes(), Optional: this is now the only caller of TrackDifference(). You could move the implementation into this method and get rid of the separate function.
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Send encoded_body_length to renderer when response completed (3/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ This CL drops encoded_body_length field from ResourceMsg_DataReceived and ResourceMsg_InlinedDataChunkReceived. This CL doesn't change the behavior. BUG=666216 ========== to ========== Send encoded_body_length to renderer when response completed (3/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG... This CL drops encoded_body_length field from ResourceMsg_DataReceived and ResourceMsg_InlinedDataChunkReceived. This CL doesn't change the behavior. BUG=666216 ==========
lgtm/2
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
yhirano@chromium.org changed reviewers: + tsepez@chromium.org
+tsepez@ for content/common/resource_messages.h.
RS LGTM, message is to renderer from a more trusted source.
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yhirano@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ricea@chromium.org, tsepez@chromium.org, kinuko@chromium.org, tzik@chromium.org Link to the patchset: https://codereview.chromium.org/2506363005/#ps80001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480355684275720,
"parent_rev": "0282f508807f90ee48ba84c859bd54f235f27830", "commit_rev":
"931553a0e16453d8cce9bc6e1bcacdf673ccdbc7"}
Message was sent while issue was closed.
Description was changed from ========== Send encoded_body_length to renderer when response completed (3/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG... This CL drops encoded_body_length field from ResourceMsg_DataReceived and ResourceMsg_InlinedDataChunkReceived. This CL doesn't change the behavior. BUG=666216 ========== to ========== Send encoded_body_length to renderer when response completed (3/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG... This CL drops encoded_body_length field from ResourceMsg_DataReceived and ResourceMsg_InlinedDataChunkReceived. This CL doesn't change the behavior. BUG=666216 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Send encoded_body_length to renderer when response completed (3/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG... This CL drops encoded_body_length field from ResourceMsg_DataReceived and ResourceMsg_InlinedDataChunkReceived. This CL doesn't change the behavior. BUG=666216 ========== to ========== Send encoded_body_length to renderer when response completed (3/3) Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived IPC message. With this series of CLs, it will be dispatched when a resource loading is completed. This is needed to use mojo data pipe for transferring the response body. - 1/3: https://codereview.chromium.org/2514713002/ - 2/3: https://codereview.chromium.org/2510333002/ - 3/3: https://codereview.chromium.org/2506363005/ Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaG... This CL drops encoded_body_length field from ResourceMsg_DataReceived and ResourceMsg_InlinedDataChunkReceived. This CL doesn't change the behavior. BUG=666216 Committed: https://crrev.com/ce1c7996be64c3af7243256c5032f11aef6fe7cd Cr-Commit-Position: refs/heads/master@{#434684} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/ce1c7996be64c3af7243256c5032f11aef6fe7cd Cr-Commit-Position: refs/heads/master@{#434684} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
