Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2515313005: [Android] Reduce visibility of Tab#getTabObservers. (Closed)

Created:
4 years ago by Ted C
Modified:
4 years ago
Reviewers:
Yusuf
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Reduce visibility of Tab#getTabObservers. By being public, it was too easy for an external class to broadcast all sort of tab notifications. By being protected, it is restricted to the dependent classes within the tab package. BUG= Committed: https://crrev.com/e4d0e88719f3f078e62f521558d3ed10c0250b3b Cr-Commit-Position: refs/heads/master@{#434673}

Patch Set 1 #

Messages

Total messages: 13 (6 generated)
Ted C
PTAL
4 years ago (2016-11-23 00:28:46 UTC) #2
Yusuf
lgtm
4 years ago (2016-11-24 00:12:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515313005/1
4 years ago (2016-11-24 00:16:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
4 years ago (2016-11-24 02:17:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515313005/1
4 years ago (2016-11-28 16:54:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 17:25:18 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-28 17:27:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4d0e88719f3f078e62f521558d3ed10c0250b3b
Cr-Commit-Position: refs/heads/master@{#434673}

Powered by Google App Engine
This is Rietveld 408576698