chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserverTest.java - Issue 2515313005: [Android] Reduce visibility of Tab#getTabObservers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserverTest.java

Issue 2515313005: [Android] Reduce visibility of Tab#getTabObservers. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/tab/TabTestUtils.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/BrandColorTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserverTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserverTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserverTest.java

index ca4af1b15d853f298e6c472dfbba82a34e68d515..531b0ce5098d37d6c685104d2a38af2779ab2eee 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserverTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserverTest.java

@@ -11,6 +11,7 @@ import android.test.suitebuilder.annotation.SmallTest;

import org.chromium.base.ObserverList;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tab.TabObserver;

+import org.chromium.chrome.browser.tab.TabTestUtils;

import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;

import org.chromium.content_public.browser.LoadUrlParams;

@@ -122,7 +123,8 @@ public class TabModelSelectorTabObserverTest extends TabModelSelectorObserverTes

}

private void assertTabHasObserver(Tab tab, TabObserver observer) {

- ObserverList.RewindableIterator<TabObserver> tabObservers = tab.getTabObservers();

+ ObserverList.RewindableIterator<TabObserver> tabObservers =

+ TabTestUtils.getTabObservers(tab);

tabObservers.rewind();

boolean containsObserver = false;

while (tabObservers.hasNext()) {

@@ -135,7 +137,8 @@ public class TabModelSelectorTabObserverTest extends TabModelSelectorObserverTes

}

private void assertTabDoesNotHaveObserver(Tab tab, TabObserver observer) {

- ObserverList.RewindableIterator<TabObserver> tabObservers = tab.getTabObservers();

+ ObserverList.RewindableIterator<TabObserver> tabObservers =

+ TabTestUtils.getTabObservers(tab);

tabObservers.rewind();

while (tabObservers.hasNext()) {

MoreAsserts.assertNotEqual(tabObservers.next(), observer);