Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2515313003: [chromedriver] Drop support for M53 and add M56 (Closed)

Created:
4 years, 1 month ago by gmanikpure
Modified:
4 years ago
Reviewers:
samuong
CC:
chromium-reviews, samuong+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Drop support for M53 and add M56 BUG= Committed: https://crrev.com/807855a39ee75ed0b9f09bb025e07a831a1d34cb Cr-Commit-Position: refs/heads/master@{#437728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/test/chromedriver/chrome/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/test/run_all_tests.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
gmanikpure
Hi Sam, New branch M56 is released and has a branch cut off : 2924 ...
4 years, 1 month ago (2016-11-21 22:10:16 UTC) #2
samuong
lgtm, but as discussed let's not land this until after chrome 55 is released
4 years, 1 month ago (2016-11-22 18:30:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515313003/1
4 years ago (2016-12-10 00:44:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-10 02:34:44 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-12 15:05:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/807855a39ee75ed0b9f09bb025e07a831a1d34cb
Cr-Commit-Position: refs/heads/master@{#437728}

Powered by Google App Engine
This is Rietveld 408576698