Issue 25153002: Enable compiling GN by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25153002: Enable compiling GN by default. (Closed)

Created:
7 years, 2 months ago by brettw

Modified:
7 years, 2 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Enable compiling GN by default. This removes the call to RestoreDefaultExceptionHandler on Mac. This isn't exported by base so breaks on the component build. IT doesn't matter since this is only related to breakpad which we don't use, so I just removed the call. BUG=288991 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226050

Patch Set 1 #

Patch Set 2 : Don't run on IOS #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -17 lines)			Patch
M	build/all.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gn/err.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/function_exec_script.cc	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tools/gn/function_write_file.cc	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tools/gn/input_file_manager.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/ninja_target_writer.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/gn/operators.cc	View	1 2 3	1 chunk	+5 lines, -3 lines	0 comments	Download
M	tools/gn/standard_out.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/gn/string_utils.cc	View	1 2 3 4	1 chunk	+4 lines, -2 lines	0 comments	Download
M	tools/gn/target_unittest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/trace.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

7 years, 2 months ago (2013-09-30 21:25:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r226050 (presubmit successful).