Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: tools/gn/string_utils.cc

Issue 25153002: Enable compiling GN by default. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set:  Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/standard_out.cc ('k') | tools/gn/target_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/string_utils.cc
diff --git a/tools/gn/string_utils.cc b/tools/gn/string_utils.cc
index 2812af9d6f85216c8a35f971dac08c5a03b00c2f..60e4e8c16c5cb44fc140edab69457189518fff73 100644
--- a/tools/gn/string_utils.cc
+++ b/tools/gn/string_utils.cc
@@ -18,12 +18,14 @@ Err ErrInsideStringToken(const Token& token, size_t offset, size_t size,
const std::string& msg,
const std::string& help = std::string()) {
// The "+1" is skipping over the " at the beginning of the token.
+ int int_offset = static_cast<int>(offset);
Location begin_loc(token.location().file(),
token.location().line_number(),
- token.location().char_offset() + offset + 1);
+ token.location().char_offset() + int_offset + 1);
Location end_loc(token.location().file(),
token.location().line_number(),
- token.location().char_offset() + offset + 1 + size);
+ token.location().char_offset() + int_offset + 1 +
+ static_cast<int>(size));
return Err(LocationRange(begin_loc, end_loc), msg, help);
}
« no previous file with comments | « tools/gn/standard_out.cc ('k') | tools/gn/target_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698