Update hard-coded search engines favicon URLs.

Update hard-coded search engines favicon URLs.

BUG=608069

[dpapad, 2016-11-22 00:54:47]

Description was changed from

==========
Updated hardcoded Bing favicon URL.

BUG=608069
==========

to

==========
Updated hard-coded search engines favicon URLs.

BUG=608069
==========

[dpapad, 2016-11-23 19:11:10]

Description was changed from

==========
Updated hard-coded search engines favicon URLs.

BUG=608069
==========

to

==========
Update hard-coded search engines favicon URLs.

BUG=608069
==========

[Peter Kasting, 2016-12-01 04:56:22]

pkasting@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2016-12-01 04:56:22]

https://codereview.chromium.org/2515223004/diff/20001/components/search_engin...
File components/search_engines/prepopulated_engines.json (right):

https://codereview.chromium.org/2515223004/diff/20001/components/search_engin...
components/search_engines/prepopulated_engines.json:91: "favicon_url":
"http://www.bing.com/sa/simg/bing_p_rr_teal_min.ico",
Why did you change the scheme here?  The link rel tag does not force HTTP, and
the search URL here (which is what users who use this engine will land on) uses
HTTPS.

https://codereview.chromium.org/2515223004/diff/20001/components/search_engin...
components/search_engines/prepopulated_engines.json:114: "favicon_url":
"https://www.google.com/favicon.ico",
This doesn't seem to match the link rel tag on the current SRP, which links to
https://www.google.com/images/branding/product/ico/googleg_lodp.ico .

[dpapad, 2016-12-08 22:58:39]

https://codereview.chromium.org/2515223004/diff/20001/components/search_engin...
File components/search_engines/prepopulated_engines.json (right):

https://codereview.chromium.org/2515223004/diff/20001/components/search_engin...
components/search_engines/prepopulated_engines.json:91: "favicon_url":
"http://www.bing.com/sa/simg/bing_p_rr_teal_min.ico",
On 2016/12/01 at 04:56:22, Peter Kasting wrote:
> Why did you change the scheme here?  The link rel tag does not force HTTP, and
the search URL here (which is what users who use this engine will land on) uses
HTTPS.

This string needs to match exactly (including the scheme) with what is returned
to the UI at [1] and [2]. Same holds for the other comment below. You have
already seen my more in-depth findings [3] explaining how something is broken
design-wise in the end-to-end favicon flow. I was not planning to just land this
CL, but I just wanted to showcase what is broken (for the pre-defined search
engines).

[1] New settings:
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/search_...
[2] Old settings:
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/options/search_e...
[3]
https://docs.google.com/document/d/1YN4OkEOi5gskFFiTuW8N93kFOdD6MJuEBq4wF__iF...

[Peter Kasting, 2016-12-08 23:01:02]

https://codereview.chromium.org/2515223004/diff/20001/components/search_engin...
File components/search_engines/prepopulated_engines.json (right):

https://codereview.chromium.org/2515223004/diff/20001/components/search_engin...
components/search_engines/prepopulated_engines.json:91: "favicon_url":
"http://www.bing.com/sa/simg/bing_p_rr_teal_min.ico",
On 2016/12/08 22:58:39, dpapad wrote:
> On 2016/12/01 at 04:56:22, Peter Kasting wrote:
> > Why did you change the scheme here?  The link rel tag does not force HTTP,
and
> the search URL here (which is what users who use this engine will land on)
uses
> HTTPS.
> 
> This string needs to match exactly (including the scheme) with what is
returned
> to the UI at [1] and [2].

Right, I'm just saying, the actual URL in the cache (which we need to match so
there's favicon data to show) will be based on whatever the user actually ends
up loading, and I think they will load the HTTPS URL here and the HTTP one
below.

[Peter Kasting, 2017-02-11 01:55:13]

What's the statu of this CL?

[dpapad, 2017-02-11 02:01:59]

On 2017/02/11 at 01:55:13, pkasting wrote:
> What's the statu of this CL?

It's inactive, I'll just close it for now. This CL proves that favicons for the
default search engines (the ones showing up on a clean install), are broken.
Updating the hardcoded favicons to match the current favicons served from those
pages fixes the issue, but it will break again when any of those search engines
decide to change their favicon URL.

[dpapad, 2017-02-11 02:02:49]

Description was changed from

==========
Update hard-coded search engines favicon URLs.

BUG=608069
==========

to

==========
Update hard-coded search engines favicon URLs.

BUG=608069
==========