Update hard-coded search engines favicon URLs.

components/search_engines/prepopulated_engines.json

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file is used during build to generate prepopulated_engine.h/cc.
 // For more details see tools/json_to_struct/json_to_struct.py.
 
 // Engine definitions. See prepopulated_engines_schema.json for the field
 // definitions.
 
@@ skipping 70 matching lines @@
       "favicon_url": "http://www.baidu.com/favicon.ico",
       "search_url": "http://www.baidu.com/#ie={inputEncoding}&wd={searchTerms}",
       "suggest_url": "http://suggestion.baidu.com/su?wd={searchTerms}&action=opensearch&ie={inputEncoding}",
       "type": "SEARCH_ENGINE_BAIDU",
       "id": 21
     },
 
     "bing": {
       "name": "Bing",
       "keyword": "bing.com",
-      "favicon_url": "https://www.bing.com/s/a/bing_p.ico",
+      "favicon_url": "http://www.bing.com/sa/simg/bing_p_rr_teal_min.ico",

[Peter Kasting, 2016/12/01 04:56:22]

Why did you change the scheme here?  The link rel tag does not force HTTP, and
the search URL here (which is what users who use this engine will land on) uses
HTTPS.

[dpapad, 2016/12/08 22:58:39]

This string needs to match exactly (including the scheme) with what is returned
to the UI at [1] and [2]. Same holds for the other comment below. You have
already seen my more in-depth findings [3] explaining how something is broken
design-wise in the end-to-end favicon flow. I was not planning to just land this
CL, but I just wanted to showcase what is broken (for the pre-defined search
engines).

[1] New settings:
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/search_...
[2] Old settings:
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/options/search_e...
[3]
https://docs.google.com/document/d/1YN4OkEOi5gskFFiTuW8N93kFOdD6MJuEBq4wF__iF...

[Peter Kasting, 2016/12/08 23:01:02]

Right, I'm just saying, the actual URL in the cache (which we need to match so
there's favicon data to show) will be based on whatever the user actually ends
up loading, and I think they will load the HTTPS URL here and the HTTP one
below.

       "search_url": "https://www.bing.com/search?q={searchTerms}&PC=U316&FORM=CHROMN",
       "suggest_url": "https://www.bing.com/osjson.aspx?query={searchTerms}&language={language}&PC=U316",
       "image_url": "https://www.bing.com/images/detail/search?iss=sbi&FORM=CHROMI#enterInsights",
       "new_tab_url": "https://www.bing.com/chrome/newtab",
       "image_url_post_params": "imgurl={google:imageURL}",
       "type": "SEARCH_ENGINE_BING",
       "id": 3
     },
 
     "daum": {
       "name": "Daum",
       "keyword": "daum.net",
       "favicon_url": "http://search.daum.net/favicon.ico",
       "search_url": "http://search.daum.net/search?ie={inputEncoding}&q={searchTerms}",
       "suggest_url": "http://sug.search.daum.net/search_nsuggest?mod=fxjson&ie={inputEncoding}&code=utf_in_out&q={searchTerms}",
       "type": "SEARCH_ENGINE_DAUM",
       "id": 68
     },
 
     "google": {
       "name": "Google",
       "keyword": "google.com",
-      "favicon_url": "http://www.google.com/favicon.ico",
+      "favicon_url": "https://www.google.com/favicon.ico",

[Peter Kasting, 2016/12/01 04:56:22]

This doesn't seem to match the link rel tag on the current SRP, which links to
https://www.google.com/images/branding/product/ico/googleg_lodp.ico .

       "search_url": "{google:baseURL}search?q={searchTerms}&{google:RLZ}{google:originalQueryForSuggestion}{google:assistedQueryStats}{google:searchFieldtrialParameter}{google:iOSSearchLanguage}{google:searchClient}{google:sourceId}{google:instantExtendedEnabledParameter}{google:contextualSearchVersion}ie={inputEncoding}",
       "suggest_url": "{google:baseSuggestURL}search?{google:searchFieldtrialParameter}client={google:suggestClient}&gs_ri={google:suggestRid}&xssi=t&q={searchTerms}&{google:inputType}{google:cursorPosition}{google:currentPageUrl}{google:pageClassification}{google:searchVersion}{google:sessionToken}{google:prefetchQuery}sugkey={google:suggestAPIKeyParameter}",
       "instant_url": "{google:baseURL}webhp?sourceid=chrome-instant&{google:RLZ}{google:forceInstantResults}{google:instantExtendedEnabledParameter}ie={inputEncoding}",
       "image_url": "{google:baseURL}searchbyimage/upload",
       "new_tab_url": "{google:baseURL}_/chrome/newtab?{google:RLZ}{google:instantExtendedEnabledParameter}ie={inputEncoding}",
       "contextual_search_url": "{google:baseURL}_/contextualsearch?{google:contextualSearchVersion}{google:contextualSearchContextData}",
       "image_url_post_params": "encoded_image={google:imageThumbnail},image_url={google:imageURL},sbisrc={google:imageSearchSource},original_width={google:imageOriginalWidth},original_height={google:imageOriginalHeight}",
       "alternate_urls": [
         "{google:baseURL}#q={searchTerms}",
         "{google:baseURL}search#q={searchTerms}",
@@ skipping 882 matching lines @@
       "name": "Zoznam",
       "keyword": "zoznam.sk",
       "favicon_url": "http://www.zoznam.sk/favicon.ico",
       "search_url": "http://www.zoznam.sk/hladaj.fcgi?s={searchTerms}",
       "encoding": "windows-1250",
       "type": "SEARCH_ENGINE_ZOZNAM",
       "id": 85
     }
   }
 }