DevTools: cleanup breakpointManager after removal of NetworkMapping

DevTools: cleanup breakpointManager after removal of NetworkMapping

This patch gets rid of the notion of sourceFileId inside BreakpointManager.
Back in the days, sourceFileId defined a URL, translated through NetworkMapping.

Nowadays, just a URL could be used.

BUG=649837
R=dgozman

Committed: https://crrev.com/26af32c71333cfe9e18e19e94deb11d52165fb93
Cr-Commit-Position: refs/heads/master@{#433776}

[lushnikov, 2016-11-22 01:34:52]

please, take a look

[lushnikov, 2016-11-22 01:35:13]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 01:35:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-11-22 01:44:42]

lgtm

https://codereview.chromium.org/2515213005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/common/Settings.js (right):

https://codereview.chromium.org/2515213005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/common/Settings.js:707:
breakpoint.url = breakpoint.sourceFileId;
Don't you want to always set an url? Or it could be missing?

breakpoint.url = breakpoint.sourceFileId || '';

[lushnikov, 2016-11-22 02:09:47]

thanks

https://codereview.chromium.org/2515213005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/common/Settings.js (right):

https://codereview.chromium.org/2515213005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/common/Settings.js:707:
breakpoint.url = breakpoint.sourceFileId;
On 2016/11/22 01:44:41, dgozman wrote:
> Don't you want to always set an url? Or it could be missing?
> 
> breakpoint.url = breakpoint.sourceFileId || '';

Agreed. I always want this.

[lushnikov, 2016-11-22 02:10:07]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 02:10:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-11-22 02:13:01]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2016-11-22 02:13:01]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-11-22 02:13:01]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2515213005/#ps20001
(title: "set a url instead of sourceFileId")

[commit-bot: I haz the power, 2016-11-22 02:13:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 03:37:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479780781459240,
"parent_rev": "a70c71180ba3de3152f256c36ae1f806a6c2cd6a", "commit_rev":
"2bd8eaf4c6e495d031f6ae1443ef4de5405f7c4e"}

[commit-bot: I haz the power, 2016-11-22 03:38:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-22 03:40:45]

Description was changed from

==========
DevTools: cleanup breakpointManager after removal of NetworkMapping

This patch gets rid of the notion of sourceFileId inside BreakpointManager.
Back in the days, sourceFileId defined a URL, translated through NetworkMapping.

Nowadays, just a URL could be used.

BUG=649837
R=dgozman
==========

to

==========
DevTools: cleanup breakpointManager after removal of NetworkMapping

This patch gets rid of the notion of sourceFileId inside BreakpointManager.
Back in the days, sourceFileId defined a URL, translated through NetworkMapping.

Nowadays, just a URL could be used.

BUG=649837
R=dgozman

Committed: https://crrev.com/26af32c71333cfe9e18e19e94deb11d52165fb93
Cr-Commit-Position: refs/heads/master@{#433776}
==========

[commit-bot: I haz the power, 2016-11-22 03:40:46]

Patchset 2 (id:??) landed as
https://crrev.com/26af32c71333cfe9e18e19e94deb11d52165fb93
Cr-Commit-Position: refs/heads/master@{#433776}