Removing SPDY3 from the code base.

Removing SPDY3 from the code base. This is the first of several cleanup CLs, since there's lots of spdy-specific
things like SynStream/SynReply and I rather thought this was large enough
as-is.

This CL lands server change 139104482 by alyssar.

BUG=488484
Committed: https://crrev.com/c90cb5357fcdc1c4ceccd2c9284c7f6ff4214371
Cr-Commit-Position: refs/heads/master@{#434580}

[yasong, 2016-11-20 17:28:27]

The CQ bit was checked by yasong@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-20 17:28:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yasong, 2016-11-20 18:10:28]

Description was changed from

==========
Enable the new header indexing policy: indexing top headers only when headers
fill about 80% of dynamic table. Not used in production. Not protected.

This CL lands server change 138519629 by yasong.

BUG=488484
==========

to

==========
Removing SPDY3 from the code base. This is the first of several cleanup CLs,
since there's lots of spdy-specific
things like SynStream/SynReply and I rather thought this was large enough
as-is.

This CL lands server change 139104482 by alyssar.

BUG=488484
==========

[commit-bot: I haz the power, 2016-11-20 18:19:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-20 18:19:30]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[yasong, 2016-11-20 18:49:25]

The CQ bit was checked by yasong@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-20 18:49:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-20 19:38:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-20 19:38:12]

Dry run: This issue passed the CQ dry run.

[yasong, 2016-11-21 13:51:15]

yasong@chromium.org changed reviewers:
+ bnc@chromium.org

[yasong, 2016-11-21 13:51:30]

On 2016/11/21 13:51:15, yasong wrote:
> mailto:yasong@chromium.org changed reviewers:
> + mailto:bnc@chromium.org

Ready for review. Thanks!

[Bence, 2016-11-21 17:50:45]

LGTM with nits.  Thank you.

https://codereview.chromium.org/2515143002/diff/20001/net/quic/test_tools/qui...
File net/quic/test_tools/quic_test_packet_maker.cc (right):

https://codereview.chromium.org/2515143002/diff/20001/net/quic/test_tools/qui...
net/quic/test_tools/quic_test_packet_maker.cc:367: SpdySerializedFrame
spdy_frame;
Could you please combine this line with assignment below in line 372?

https://codereview.chromium.org/2515143002/diff/20001/net/spdy/spdy_framer_te...
File net/spdy/spdy_framer_test.cc (right):

https://codereview.chromium.org/2515143002/diff/20001/net/spdy/spdy_framer_te...
net/spdy/spdy_framer_test.cc:2150: #if !defined(USE_SYSTEM_ZLIB)
Please remove this commend and #if, because zlib was only used in SPDY/3.1, so
there is no workaround needed.

[chromium-reviews, 2016-11-23 09:48:40]

Hi Bence,

Is it possible that I submit this change first, and address the comments in
a different cl? I just realize I can't access my workstation where my git
directory lives, because I am in China. Do you know if I can create a new
git repository with the current change in a different workstation? Thanks!

Yang

On Mon, Nov 21, 2016 at 12:50 PM, <bnc@chromium.org> wrote:

> LGTM with nits. Thank you.
>
>
> https://codereview.chromium.org/2515143002/diff/20001/net/
> quic/test_tools/quic_test_packet_maker.cc
> File net/quic/test_tools/quic_test_packet_maker.cc (right):
>
> https://codereview.chromium.org/2515143002/diff/20001/net/
> quic/test_tools/quic_test_packet_maker.cc#newcode367
> net/quic/test_tools/quic_test_packet_maker.cc:367: SpdySerializedFrame
> spdy_frame;
> Could you please combine this line with assignment below in line 372?
>
> https://codereview.chromium.org/2515143002/diff/20001/net/
> spdy/spdy_framer_test.cc
> File net/spdy/spdy_framer_test.cc (right):
>
> https://codereview.chromium.org/2515143002/diff/20001/net/
> spdy/spdy_framer_test.cc#newcode2150
> net/spdy/spdy_framer_test.cc:2150: #if !defined(USE_SYSTEM_ZLIB)
> Please remove this commend and #if, because zlib was only used in
> SPDY/3.1, so there is no workaround needed.
>
> https://codereview.chromium.org/2515143002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Bence, 2016-11-23 13:09:00]

Hi Yang,

Yes, you can: 'git cl patch 2515143002' downloads the patch and applies it
locally and sets the patch number so that after you commit changes, 'git cl
upload' will upload to this CL.  (Also remember that you can check out Chromium
without history to save a lot on download time.)

If you run into any difficulties, feel free to land this CL without addressing
the comments, and we can deal with them later.

Cheers,

Bence

On 2016/11/23 09:48:40, chromium-reviews wrote:
> Hi Bence,
> 
> Is it possible that I submit this change first, and address the comments in
> a different cl? I just realize I can't access my workstation where my git
> directory lives, because I am in China. Do you know if I can create a new
> git repository with the current change in a different workstation? Thanks!
> 
> Yang
> 
> On Mon, Nov 21, 2016 at 12:50 PM, <mailto:bnc@chromium.org> wrote:
> 
> > LGTM with nits. Thank you.
> >
> >
> > https://codereview.chromium.org/2515143002/diff/20001/net/
> > quic/test_tools/quic_test_packet_maker.cc
> > File net/quic/test_tools/quic_test_packet_maker.cc (right):
> >
> > https://codereview.chromium.org/2515143002/diff/20001/net/
> > quic/test_tools/quic_test_packet_maker.cc#newcode367
> > net/quic/test_tools/quic_test_packet_maker.cc:367: SpdySerializedFrame
> > spdy_frame;
> > Could you please combine this line with assignment below in line 372?
> >
> > https://codereview.chromium.org/2515143002/diff/20001/net/
> > spdy/spdy_framer_test.cc
> > File net/spdy/spdy_framer_test.cc (right):
> >
> > https://codereview.chromium.org/2515143002/diff/20001/net/
> > spdy/spdy_framer_test.cc#newcode2150
> > net/spdy/spdy_framer_test.cc:2150: #if !defined(USE_SYSTEM_ZLIB)
> > Please remove this commend and #if, because zlib was only used in
> > SPDY/3.1, so there is no workaround needed.
> >
> > https://codereview.chromium.org/2515143002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[yasong, 2016-11-27 01:01:57]

The CQ bit was checked by yasong@chromium.org

[commit-bot: I haz the power, 2016-11-27 01:02:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-27 02:33:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480208517988460,
"parent_rev": "c5beee4acde168dbbeeb022bb2c5ef66aa887a87", "commit_rev":
"e15add0a8f0cae9420d123bf63e3948ab4fba870"}

[commit-bot: I haz the power, 2016-11-27 02:34:39]

Description was changed from

==========
Removing SPDY3 from the code base. This is the first of several cleanup CLs,
since there's lots of spdy-specific
things like SynStream/SynReply and I rather thought this was large enough
as-is.

This CL lands server change 139104482 by alyssar.

BUG=488484
==========

to

==========
Removing SPDY3 from the code base. This is the first of several cleanup CLs,
since there's lots of spdy-specific
things like SynStream/SynReply and I rather thought this was large enough
as-is.

This CL lands server change 139104482 by alyssar.

BUG=488484
==========

[commit-bot: I haz the power, 2016-11-27 02:34:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-27 02:37:19]

Description was changed from

==========
Removing SPDY3 from the code base. This is the first of several cleanup CLs,
since there's lots of spdy-specific
things like SynStream/SynReply and I rather thought this was large enough
as-is.

This CL lands server change 139104482 by alyssar.

BUG=488484
==========

to

==========
Removing SPDY3 from the code base. This is the first of several cleanup CLs,
since there's lots of spdy-specific
things like SynStream/SynReply and I rather thought this was large enough
as-is.

This CL lands server change 139104482 by alyssar.

BUG=488484

Committed: https://crrev.com/c90cb5357fcdc1c4ceccd2c9284c7f6ff4214371
Cr-Commit-Position: refs/heads/master@{#434580}
==========

[commit-bot: I haz the power, 2016-11-27 02:37:19]

Patchset 2 (id:??) landed as
https://crrev.com/c90cb5357fcdc1c4ceccd2c9284c7f6ff4214371
Cr-Commit-Position: refs/heads/master@{#434580}