Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: net/spdy/spdy_frame_builder_test.cc

Issue 2515143002: Removing SPDY3 from the code base. (Closed)
Patch Set: Addressed a failure on windows. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/spdy_frame_builder.h" 5 #include "net/spdy/spdy_frame_builder.h"
6 6
7 #include "net/spdy/spdy_framer.h" 7 #include "net/spdy/spdy_framer.h"
8 #include "net/spdy/spdy_protocol.h" 8 #include "net/spdy/spdy_protocol.h"
9 #include "testing/platform_test.h" 9 #include "testing/platform_test.h"
10 10
11 namespace net { 11 namespace net {
12 12
13 class SpdyFrameBuilderTest : public ::testing::TestWithParam<SpdyMajorVersion> { 13 TEST(SpdyFrameBuilderTest, GetWritableBuffer) {
14 protected:
15 void SetUp() override { spdy_version_ = GetParam(); }
16
17 // Major version of SPDY protocol to be used.
18 SpdyMajorVersion spdy_version_;
19 };
20
21 // All tests are run with SPDY/3 and HTTP/2.
22 INSTANTIATE_TEST_CASE_P(SpdyFrameBuilderTests,
23 SpdyFrameBuilderTest,
24 ::testing::Values(SPDY3, HTTP2));
25
26 TEST_P(SpdyFrameBuilderTest, GetWritableBuffer) {
27 const size_t builder_size = 10; 14 const size_t builder_size = 10;
28 SpdyFrameBuilder builder(builder_size, spdy_version_); 15 SpdyFrameBuilder builder(builder_size, HTTP2);
29 char* writable_buffer = builder.GetWritableBuffer(builder_size); 16 char* writable_buffer = builder.GetWritableBuffer(builder_size);
30 memset(writable_buffer, ~1, builder_size); 17 memset(writable_buffer, ~1, builder_size);
31 EXPECT_TRUE(builder.Seek(builder_size)); 18 EXPECT_TRUE(builder.Seek(builder_size));
32 SpdySerializedFrame frame(builder.take()); 19 SpdySerializedFrame frame(builder.take());
33 char expected[builder_size]; 20 char expected[builder_size];
34 memset(expected, ~1, builder_size); 21 memset(expected, ~1, builder_size);
35 EXPECT_EQ(base::StringPiece(expected, builder_size), 22 EXPECT_EQ(base::StringPiece(expected, builder_size),
36 base::StringPiece(frame.data(), builder_size)); 23 base::StringPiece(frame.data(), builder_size));
37 } 24 }
38 25
39 TEST_P(SpdyFrameBuilderTest, RewriteLength) { 26 TEST(SpdyFrameBuilderTest, RewriteLength) {
40 // Create an empty SETTINGS frame both via framer and manually via builder. 27 // Create an empty SETTINGS frame both via framer and manually via builder.
41 // The one created via builder is initially given the incorrect length, but 28 // The one created via builder is initially given the incorrect length, but
42 // then is corrected via RewriteLength(). 29 // then is corrected via RewriteLength().
43 SpdyFramer framer(spdy_version_); 30 SpdyFramer framer(HTTP2);
44 SpdySettingsIR settings_ir; 31 SpdySettingsIR settings_ir;
45 SpdySerializedFrame expected(framer.SerializeSettings(settings_ir)); 32 SpdySerializedFrame expected(framer.SerializeSettings(settings_ir));
46 SpdyFrameBuilder builder(expected.size() + 1, spdy_version_); 33 SpdyFrameBuilder builder(expected.size() + 1, HTTP2);
47 if (spdy_version_ == SPDY3) { 34 builder.BeginNewFrame(framer, SETTINGS, 0, 0);
48 builder.WriteControlFrameHeader(framer, SETTINGS, 0);
49 builder.WriteUInt32(0); // Write the number of settings.
50 } else {
51 builder.BeginNewFrame(framer, SETTINGS, 0, 0);
52 }
53 EXPECT_TRUE(builder.GetWritableBuffer(1) != NULL); 35 EXPECT_TRUE(builder.GetWritableBuffer(1) != NULL);
54 builder.RewriteLength(framer); 36 builder.RewriteLength(framer);
55 SpdySerializedFrame built(builder.take()); 37 SpdySerializedFrame built(builder.take());
56 EXPECT_EQ(base::StringPiece(expected.data(), expected.size()), 38 EXPECT_EQ(base::StringPiece(expected.data(), expected.size()),
57 base::StringPiece(built.data(), expected.size())); 39 base::StringPiece(built.data(), expected.size()));
58 } 40 }
59 41
60 TEST_P(SpdyFrameBuilderTest, OverwriteFlags) { 42 TEST(SpdyFrameBuilderTest, OverwriteFlags) {
61 // Create a HEADERS frame both via framer and manually via builder with 43 // Create a HEADERS frame both via framer and manually via builder with
62 // different flags set, then make them match using OverwriteFlags(). 44 // different flags set, then make them match using OverwriteFlags().
63 SpdyFramer framer(spdy_version_); 45 SpdyFramer framer(HTTP2);
64 if (spdy_version_ == SPDY3) {
65 return;
66 }
67 SpdyHeadersIR headers_ir(1); 46 SpdyHeadersIR headers_ir(1);
68 SpdySerializedFrame expected(framer.SerializeHeaders(headers_ir)); 47 SpdySerializedFrame expected(framer.SerializeHeaders(headers_ir));
69 SpdyFrameBuilder builder(expected.size(), spdy_version_); 48 SpdyFrameBuilder builder(expected.size(), HTTP2);
70 builder.BeginNewFrame(framer, HEADERS, 0, 1); 49 builder.BeginNewFrame(framer, HEADERS, 0, 1);
71 builder.OverwriteFlags(framer, HEADERS_FLAG_END_HEADERS); 50 builder.OverwriteFlags(framer, HEADERS_FLAG_END_HEADERS);
72 SpdySerializedFrame built(builder.take()); 51 SpdySerializedFrame built(builder.take());
73 EXPECT_EQ(base::StringPiece(expected.data(), expected.size()), 52 EXPECT_EQ(base::StringPiece(expected.data(), expected.size()),
74 base::StringPiece(built.data(), built.size())); 53 base::StringPiece(built.data(), built.size()));
75 } 54 }
76
77 } // namespace net 55 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698