Allow binding the vm service to IPv6 addresses.

Allow binding the vm service to IPv6 addresses.

Change the default bind address to 'localhost', which will be resolved to '127.0.0.1' or '::1' depending on the host's support for IPv6.

Fixes #27841

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/1b518894476ce14d08e9c58d708f36d4a3218a0d

[rmacnak, 2016-11-18 23:50:32]

rmacnak@google.com changed reviewers:
+ asiva@google.com, johnmccutchan@google.com

[rmacnak, 2016-11-18 23:50:33]

https://codereview.chromium.org/2515023002/diff/20001/runtime/bin/vmservice/s...
File runtime/bin/vmservice/server.dart (right):

https://codereview.chromium.org/2515023002/diff/20001/runtime/bin/vmservice/s...
runtime/bin/vmservice/server.dart:313: var address = (await
InternetAddress.lookup(_ip))[0];
On my workstation, the IPv6 result comes back first, and presumably this is a
signal that it is preferred.

[Cutch, 2016-11-19 22:21:37]

https://codereview.chromium.org/2515023002/diff/20001/runtime/bin/vmservice/s...
File runtime/bin/vmservice/server.dart (right):

https://codereview.chromium.org/2515023002/diff/20001/runtime/bin/vmservice/s...
runtime/bin/vmservice/server.dart:313: var address = (await
InternetAddress.lookup(_ip))[0];
On 2016/11/18 23:50:33, rmacnak wrote:
> On my workstation, the IPv6 result comes back first, and presumably this is a
> signal that it is preferred.

This code should stay consistent with the existing behaviour and always choose
ipv4 if it is available and then ipv6.

https://codereview.chromium.org/2515023002/diff/40001/runtime/observatory/tes...
File runtime/observatory/tests/service/auth_token_test.dart (right):

https://codereview.chromium.org/2515023002/diff/40001/runtime/observatory/tes...
runtime/observatory/tests/service/auth_token_test.dart:20:
expect(info.serverUri.pathSegments.length, greaterThan(0));
pathSegments has a length two here. so this should be 'equals(2)' or remain
'greaterThan(1)'

[rmacnak, 2016-11-22 04:00:52]

https://codereview.chromium.org/2515023002/diff/20001/runtime/bin/vmservice/s...
File runtime/bin/vmservice/server.dart (right):

https://codereview.chromium.org/2515023002/diff/20001/runtime/bin/vmservice/s...
runtime/bin/vmservice/server.dart:313: var address = (await
InternetAddress.lookup(_ip))[0];
On 2016/11/19 22:21:37, Cutch wrote:
> On 2016/11/18 23:50:33, rmacnak wrote:
> > On my workstation, the IPv6 result comes back first, and presumably this is
a
> > signal that it is preferred.
> 
> This code should stay consistent with the existing behaviour and always choose
> ipv4 if it is available and then ipv6.

Done.

https://codereview.chromium.org/2515023002/diff/40001/runtime/observatory/tes...
File runtime/observatory/tests/service/auth_token_test.dart (right):

https://codereview.chromium.org/2515023002/diff/40001/runtime/observatory/tes...
runtime/observatory/tests/service/auth_token_test.dart:20:
expect(info.serverUri.pathSegments.length, greaterThan(0));
On 2016/11/19 22:21:37, Cutch wrote:
> pathSegments has a length two here. so this should be 'equals(2)' or remain
> 'greaterThan(1)'

adjusted serverAddress to make this true again

[siva, 2016-11-22 05:25:04]

What was the decision on binding to both 127.0.0.1 and ::1 at the same port, is
that a useful thing to do?

[Cutch, 2016-11-23 20:32:17]

On 2016/11/22 05:25:04, siva wrote:
> What was the decision on binding to both 127.0.0.1 and ::1 at the same port,
is
> that a useful thing to do?

I believe that is a flaky thing to do. We have a unit test that tries to do that
and it fails regularly.

[Cutch, 2016-11-23 20:33:14]

lgtm

[rmacnak, 2016-11-23 22:24:57]

Description was changed from

==========
Allow binding the vm service to IPv6 addresses.

Change the default bind address to 'localhost', which will be resolved to
'127.0.0.1' or '::1' depending on the host's support for IPv6.

Fixes #27841
==========

to

==========
Allow binding the vm service to IPv6 addresses.

Change the default bind address to 'localhost', which will be resolved to
'127.0.0.1' or '::1' depending on the host's support for IPv6.

Fixes #27841

R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1b518894476ce14d08e9c58d708f36d4a3218a0d
==========

[rmacnak, 2016-11-23 22:24:58]

Committed patchset #4 (id:60001) manually as
1b518894476ce14d08e9c58d708f36d4a3218a0d (presubmit successful).