Allow binding the vm service to IPv6 addresses.

runtime/bin/vmservice/server.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of vmservice_io;
 
 class WebSocketClient extends Client {
   static const int PARSE_ERROR_CODE = 4000;
   static const int BINARY_MESSAGE_ERROR_CODE = 4001;
   static const int NOT_MAP_ERROR_CODE = 4002;
@@ skipping 117 matching lines @@
   bool get running => _server != null;
 
   /// Returns the server address including the auth token.
   Uri get serverAddress {
     if (!running) {
       return null;
     }
     var ip = _server.address.address;
     var port = _server.port;
     if (useAuthToken) {
-      return Uri.parse('http://$ip:$port/$serviceAuthToken/');
+      return new Uri(scheme: 'http', host: ip, port: port,
+                     path: serviceAuthToken);
     } else {
-      return Uri.parse('http://$ip:$port/');
+      return new Uri(scheme: 'http', host: ip, port: port);
     }
   }
 
   Server(this._service, this._ip, this._port, this._originCheckDisabled);
 
   bool _isAllowedOrigin(String origin) {
     Uri uri;
     try {
       uri = Uri.parse(origin);
     } catch (_) {
       return false;
     }
 
     // Explicitly add localhost and 127.0.0.1 on any port (necessary for
     // adb port forwarding).
     if ((uri.host == 'localhost') ||
+        (uri.host == '::1') ||
         (uri.host == '127.0.0.1')) {
       return true;
     }
 
     if ((uri.port == _server.port) &&
         ((uri.host == _server.address.address) ||
          (uri.host == _server.address.host))) {
       return true;
     }
 
@@ skipping 126 matching lines @@
       var client = new HttpRequestClient(request, _service);
       var message = new Message.fromUri(client, request.uri);
       client.onMessage(null, message);
     } catch (e) {
       print('Unexpected error processing HTTP request uri: '
             '${request.uri}\n$e\n');
       rethrow;
     }
   }
 
-  Future startup() {
+  Future startup() async {
     if (_server != null) {
       // Already running.
-      return new Future.value(this);
+      return this;
     }
 
-    var address = new InternetAddress(_ip);
     // Startup HTTP server.
-    return HttpServer.bind(address, _port).then((s) {
-      _server = s;
+    try {
+      var address = (await InternetAddress.lookup(_ip))[0];

[rmacnak, 2016/11/18 23:50:33]

On my workstation, the IPv6 result comes back first, and presumably this is a
signal that it is preferred.

[Cutch, 2016/11/19 22:21:37]

This code should stay consistent with the existing behaviour and always choose
ipv4 if it is available and then ipv6.

[rmacnak, 2016/11/22 04:00:52]

Done.

+      _server = await HttpServer.bind(address, _port);
       _server.listen(_requestHandler, cancelOnError: true);
       print('Observatory listening on $serverAddress');
       // Server is up and running.
       _notifyServerState(serverAddress.toString());
       onServerAddressChange('$serverAddress');
       return this;
-    }).catchError((e, st) {
+    } catch (e, st) {
       print('Could not start Observatory HTTP server:\n$e\n$st\n');
       _notifyServerState("");
       onServerAddressChange(null);
       return this;
-    });
+    }
   }
 
   Future cleanup(bool force) {
     if (_server == null) {
       return new Future.value(null);
     }
     return _server.close(force: force);
   }
 
   Future shutdown(bool forced) {
@@ skipping 16 matching lines @@
       _notifyServerState("");
       onServerAddressChange(null);
       return this;
     });
   }
 
 }
 
 void _notifyServerState(String uri)
     native "VMServiceIO_NotifyServerState";