Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2514973002: Revert of tcmalloc: Use futex syscall in SpinLockDelay() for ARM. (Closed)

Created:
4 years, 1 month ago by cavalcantii1
Modified:
4 years, 1 month ago
CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of tcmalloc: Use futex syscall in SpinLockDelay() for ARM. (patchset #5 id:80001 of https://codereview.chromium.org/2457473003/ ) Reason for revert: It seems that a ChromeOS build with clang has failed, details on: https://bugs.chromium.org/p/chromium/issues/detail?id=666839 We will revert the patch while the issue is being investigated. Original issue's description: > tcmalloc: Use futex syscall in SpinLockDelay() for ARM. > > SpinLockDelay() was avoiding using futex() when compiled for ARM. > The alternative implementation was sleeping for 2 ms. This caused > performance issues in Telemetry's SvgCubics benchmark. The score for > this benchmark more than doubles when this patch is applied (scores were > measured on veyron_jerry, veyron_minnie, daisy). Other benchmarks > (blink_perf.bindings/post-message, blink_perf.canvas/draw-static-webgl- > to-hw-accelerated-canvas-2d) benefit from this change to a lesser > extent. This patch also removes a reference to futex1 in a comment in > linux-syscall_support.h, as this is not a valid syscall name. > > Note that a similar fix was pushed in the upstream version of tcmalloc > (issue-693, https://github.com/gperftools/gperftools/commit/7df7f14). > > BUG= > > Change-Id: I390ac51ed5e1b0ad021ac63eaf3bce81cdca8599 > Committed: https://crrev.com/7f1336053e39737671a52ca7a265007e9024ee8a > Cr-Commit-Position: refs/heads/master@{#432628} TBR=wfh@chromium.org,thakis@chromium.org,primiano@chromium.org,matteo.franchin@arm.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/91996d7dd9c5cb939e40cf33e300fd0b3dace5fb Cr-Commit-Position: refs/heads/master@{#433305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/tcmalloc/README.chromium View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/tcmalloc/chromium/src/base/linux_syscall_support.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/tcmalloc/chromium/src/base/spinlock_linux-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
cavalcantii1
Created Revert of tcmalloc: Use futex syscall in SpinLockDelay() for ARM.
4 years, 1 month ago (2016-11-18 20:59:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514973002/1
4 years, 1 month ago (2016-11-18 21:00:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 21:44:13 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 21:48:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91996d7dd9c5cb939e40cf33e300fd0b3dace5fb
Cr-Commit-Position: refs/heads/master@{#433305}

Powered by Google App Engine
This is Rietveld 408576698