Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1846)

Issue 2514943002: [Android] Clean up gtest stdout handling. (Closed)

Created:
4 years, 1 month ago by jbudorick
Modified:
4 years ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Clean up gtest stdout handling. including: - capturing partial stdout for failed shards - removing vestigial fifo support - removing on-device results parsing BUG=646223 Committed: https://crrev.com/cea883202f2e33a6b48b643b3d57221a2ef6187e Cr-Commit-Position: refs/heads/master@{#434982}

Patch Set 1 #

Patch Set 2 : slight cleaning #

Total comments: 2

Patch Set 3 : mikecase comment #

Patch Set 4 : write/update -> append/update #

Patch Set 5 : write/update -> append/update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -210 lines) Patch
M build/android/pylib/local/device/local_device_gtest_run.py View 1 2 2 chunks +16 lines, -4 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeTest.java View 4 chunks +2 lines, -7 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java View 1 2 7 chunks +20 lines, -189 lines 0 comments Download
M testing/android/native_test/native_test_launcher.cc View 1 2 3 4 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 27 (18 generated)
jbudorick
This should also help the case where an individual gtest shard times out, which has ...
4 years, 1 month ago (2016-11-18 20:11:26 UTC) #2
jbudorick
ping
4 years ago (2016-11-21 16:37:43 UTC) #5
mikecase (-- gone --)
lgtm w/ one unused constant you can delete. Also, was the Java gtest parsing logic ...
4 years ago (2016-11-21 18:26:23 UTC) #6
jbudorick
Java gtest parsing was used for appurify. https://codereview.chromium.org/2514943002/diff/20001/testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java File testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java (right): https://codereview.chromium.org/2514943002/diff/20001/testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java#newcode58 testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java:58: private static ...
4 years ago (2016-11-21 18:56:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514943002/40001
4 years ago (2016-11-21 18:57:41 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/72119)
4 years ago (2016-11-21 20:21:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514943002/80001
4 years ago (2016-11-29 13:56:25 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-11-29 14:00:35 UTC) #25
commit-bot: I haz the power
4 years ago (2016-11-29 14:03:38 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/cea883202f2e33a6b48b643b3d57221a2ef6187e
Cr-Commit-Position: refs/heads/master@{#434982}

Powered by Google App Engine
This is Rietveld 408576698