Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: testing/android/native_test/java/src/org/chromium/native_test/NativeTest.java

Issue 2514943002: [Android] Clean up gtest stdout handling. (Closed)
Patch Set: write/update -> append/update Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: testing/android/native_test/java/src/org/chromium/native_test/NativeTest.java
diff --git a/testing/android/native_test/java/src/org/chromium/native_test/NativeTest.java b/testing/android/native_test/java/src/org/chromium/native_test/NativeTest.java
index 537c5efc777aab2ba1c4f86cf3445fc5623661be..4352205a23aa611bda3d7fc587056f336dfc1810 100644
--- a/testing/android/native_test/java/src/org/chromium/native_test/NativeTest.java
+++ b/testing/android/native_test/java/src/org/chromium/native_test/NativeTest.java
@@ -45,7 +45,6 @@ public class NativeTest {
private StringBuilder mCommandLineFlags = new StringBuilder();
private TestStatusReporter mReporter;
private boolean mRunInSubThread = false;
- private boolean mStdoutFifo = false;
private String mStdoutFilePath;
private static class ReportingUncaughtExceptionHandler
@@ -122,10 +121,6 @@ public class NativeTest {
}
mStdoutFilePath = intent.getStringExtra(EXTRA_STDOUT_FILE);
- if (mStdoutFilePath == null) {
- mStdoutFilePath = new File(activity.getFilesDir(), "test.fifo").getAbsolutePath();
- mStdoutFifo = true;
- }
}
public void appendCommandLineFlags(String flags) {
@@ -155,7 +150,7 @@ public class NativeTest {
private void runTests(Activity activity) {
nativeRunTests(mCommandLineFlags.toString(), mCommandLineFilePath, mStdoutFilePath,
- mStdoutFifo, activity.getApplicationContext(), UrlUtils.getIsolatedTestRoot());
+ activity.getApplicationContext(), UrlUtils.getIsolatedTestRoot());
activity.finish();
mReporter.testRunFinished(Process.myPid());
}
@@ -168,5 +163,5 @@ public class NativeTest {
}
private native void nativeRunTests(String commandLineFlags, String commandLineFilePath,
- String stdoutFilePath, boolean stdoutFifo, Context appContext, String testDataDir);
+ String stdoutFilePath, Context appContext, String testDataDir);
}

Powered by Google App Engine
This is Rietveld 408576698