Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2514923002: content: Use mus client-lib's gpu-service from renderers. (Closed)

Created:
4 years, 1 month ago by sadrul
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, creis+watch_chromium.org, danakj, darin (slow to review), darin-cc_chromium.org, enne (OOO), feature-media-reviews_chromium.org, Fady Samuel, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, piman+watch_chromium.org, piman, posciak+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Use mus client-lib's gpu-service from renderers. Switch over to using the gpu service from renderer processes on all platforms. The service is used to create the gpu-channel, and allocate gpu memory buffers. Notable changes. . Introduce content::GpuClient in content-browser as the implementation of the mojom::Gpu interface. The GpuClient currently implements the interface with the existing code. In future CLs, this will be updated to look more like ui::ws::GpuClient. . RenderProcessHostImpl creates and owns the GpuClient for each renderer process. The GpuClient lives and operates on the IO thread. . ui::Gpu is created and owned by the RenderThreadImpl (as it is right now in --mash mode). . ui::Gpu is updated to work with a service_manager::InterfaceProvider (which is available in a regular chrome) if a Connector is unavailable. BUG=643746 Committed: https://crrev.com/53546591865acbacdc0a3e229933f591b3f08f2d Cr-Commit-Position: refs/heads/master@{#439282}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : tot merge #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : dup #

Patch Set 13 : better-mach #

Patch Set 14 : . #

Patch Set 15 : . #

Patch Set 16 : . #

Patch Set 17 : . #

Patch Set 18 : . #

Patch Set 19 : . #

Patch Set 20 : . #

Patch Set 21 : . #

Patch Set 22 : . #

Patch Set 23 : tot merge #

Patch Set 24 : . #

Patch Set 25 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -338 lines) Patch
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +1 line, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +2 lines, -0 lines 0 comments Download
A content/browser/gpu/gpu_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +51 lines, -0 lines 0 comments Download
A content/browser/gpu/gpu_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +107 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 3 chunks +0 lines, -23 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 6 chunks +0 lines, -91 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 4 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 3 chunks +11 lines, -0 lines 0 comments Download
M content/child/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +0 lines, -2 lines 0 comments Download
D content/child/child_gpu_memory_buffer_manager.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +0 lines, -38 lines 0 comments Download
D content/child/child_gpu_memory_buffer_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +0 lines, -74 lines 0 comments Download
M content/common/child_process_messages.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +0 lines, -22 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 3 chunks +6 lines, -3 lines 0 comments Download
M content/renderer/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/renderer_gpu_video_accelerator_factories.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 6 chunks +1 line, -15 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 6 chunks +7 lines, -50 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl_discardable_memory_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/public/cpp/gpu/gpu.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 4 chunks +7 lines, -1 line 0 comments Download
M services/ui/public/cpp/gpu/gpu.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 6 chunks +30 lines, -14 lines 0 comments Download

Messages

Total messages: 110 (99 generated)
sadrul
Hello! reveman@ Would you mind reviewing this since this affects how GPU memory buffers are ...
4 years ago (2016-12-09 21:25:55 UTC) #81
jam
lgtm
4 years ago (2016-12-10 00:05:52 UTC) #84
sadrul
+tsepez@ for content/common and the manifest file in content/public/app/mojo +jbauman@ is a gpu owner
4 years ago (2016-12-12 19:29:05 UTC) #86
Tom Sepez
lgtm
4 years ago (2016-12-12 19:42:41 UTC) #87
reveman
lgtm % hshi's review who recently fixed some gpu process startup race conditions on cros ...
4 years ago (2016-12-12 21:59:24 UTC) #89
sadrul
On 2016/12/12 21:59:24, reveman wrote: > lgtm % hshi's review who recently fixed some gpu ...
4 years ago (2016-12-12 23:26:32 UTC) #90
jbauman
lgtm
4 years ago (2016-12-13 03:28:04 UTC) #91
reveman
On 2016/12/12 at 23:26:32, sadrul wrote: > On 2016/12/12 21:59:24, reveman wrote: > > lgtm ...
4 years ago (2016-12-13 15:02:45 UTC) #92
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514923002/480001
4 years ago (2016-12-17 00:37:10 UTC) #105
commit-bot: I haz the power
Committed patchset #25 (id:480001)
4 years ago (2016-12-17 01:45:02 UTC) #108
commit-bot: I haz the power
4 years ago (2016-12-17 01:48:26 UTC) #110
Message was sent while issue was closed.
Patchset 25 (id:??) landed as
https://crrev.com/53546591865acbacdc0a3e229933f591b3f08f2d
Cr-Commit-Position: refs/heads/master@{#439282}

Powered by Google App Engine
This is Rietveld 408576698