Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3263)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/allocator/BUILD.gn

Issue 2514903002: Update reason for disabling thumb in tcmalloc (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/allocator/BUILD.gn
diff --git a/base/allocator/BUILD.gn b/base/allocator/BUILD.gn
index 1f69f9538c75af5c85c281624a4db69990ea20f9..cffe6c28db26e8aabc191ad85b9e94a9f1f783e9 100644
--- a/base/allocator/BUILD.gn
+++ b/base/allocator/BUILD.gn
@@ -219,7 +219,8 @@ if (use_allocator == "tcmalloc") {
configs -= [
"//build/config/compiler:chromium_code",
- # The asm code in tcmalloc is not currently thumb compatible
+ # Thumb mode disabled due to bug in clang integrated assembler
+ # TODO(https://llvm.org/bugs/show_bug.cgi?id=31058)
"//build/config/compiler:compiler_arm_thumb",
]
configs += [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698