Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: base/allocator/BUILD.gn

Issue 2514903002: Update reason for disabling thumb in tcmalloc (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/allocator.gni") 6 import("//build/config/allocator.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 8
9 declare_args() { 9 declare_args() {
10 # Provide a way to force disable debugallocation in Debug builds, 10 # Provide a way to force disable debugallocation in Debug builds,
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 212
213 include_dirs = [ 213 include_dirs = [
214 ".", 214 ".",
215 "$tcmalloc_dir/src/base", 215 "$tcmalloc_dir/src/base",
216 "$tcmalloc_dir/src", 216 "$tcmalloc_dir/src",
217 ] 217 ]
218 218
219 configs -= [ 219 configs -= [
220 "//build/config/compiler:chromium_code", 220 "//build/config/compiler:chromium_code",
221 221
222 # The asm code in tcmalloc is not currently thumb compatible 222 # Thumb mode disabled due to bug in clang integrated assembler
223 # TODO(https://llvm.org/bugs/show_bug.cgi?id=31058)
223 "//build/config/compiler:compiler_arm_thumb", 224 "//build/config/compiler:compiler_arm_thumb",
224 ] 225 ]
225 configs += [ 226 configs += [
226 "//build/config/compiler:no_chromium_code", 227 "//build/config/compiler:no_chromium_code",
227 ":tcmalloc_flags", 228 ":tcmalloc_flags",
228 ] 229 ]
229 230
230 # TODO(crbug.com/633719) Make tcmalloc work with AFDO if possible. 231 # TODO(crbug.com/633719) Make tcmalloc work with AFDO if possible.
231 configs -= [ "//build/config/compiler:afdo" ] 232 configs -= [ "//build/config/compiler:afdo" ]
232 233
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
340 sources += [ "allocator_shim_default_dispatch_to_glibc.cc" ] 341 sources += [ "allocator_shim_default_dispatch_to_glibc.cc" ]
341 } else if (is_android && use_allocator == "none") { 342 } else if (is_android && use_allocator == "none") {
342 sources += [ 343 sources += [
343 "allocator_shim_default_dispatch_to_linker_wrapped_symbols.cc", 344 "allocator_shim_default_dispatch_to_linker_wrapped_symbols.cc",
344 "allocator_shim_override_linker_wrapped_symbols.h", 345 "allocator_shim_override_linker_wrapped_symbols.h",
345 ] 346 ]
346 all_dependent_configs = [ ":wrap_malloc_symbols" ] 347 all_dependent_configs = [ ":wrap_malloc_symbols" ]
347 } 348 }
348 } 349 }
349 } 350 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698