Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2514903002: Update reason for disabling thumb in tcmalloc (Closed)

Created:
4 years, 1 month ago by Sam Clegg
Modified:
4 years, 1 month ago
Reviewers:
brettw, Roland McGrath
CC:
chromium-reviews, wfh+watch_chromium.org, Dai Mikurube (NOT FULLTIME), Roland McGrath
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update reason for disabling thumb in tcmalloc BUG=564059 Committed: https://crrev.com/59bb1490cf3a7e740352143d02f764eeda98dff0 Cr-Commit-Position: refs/heads/master@{#433368}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M base/allocator/BUILD.gn View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Sam Clegg
4 years, 1 month ago (2016-11-18 17:14:56 UTC) #2
Roland McGrath
lgtm
4 years, 1 month ago (2016-11-18 18:09:09 UTC) #4
brettw
lgtm
4 years, 1 month ago (2016-11-18 21:16:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514903002/40001
4 years, 1 month ago (2016-11-18 22:15:40 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-19 01:14:37 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 01:17:07 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/59bb1490cf3a7e740352143d02f764eeda98dff0
Cr-Commit-Position: refs/heads/master@{#433368}

Powered by Google App Engine
This is Rietveld 408576698