Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2514693004: Revert of Remove redundant 'derived constraint space' setters from NGConstraintSpace (Closed)

Created:
4 years, 1 month ago by sadrul
Modified:
4 years, 1 month ago
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove redundant 'derived constraint space' setters from NGConstraintSpace (patchset #2 id:40001 of https://codereview.chromium.org/2515923002/ ) Reason for revert: Causing wide-spread build failures, with errors like: ../../third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc:74:13: error: no member named 'Size' in 'blink::NGConstraintSpace' space.Size().ConvertToPhysical(space.WritingMode()); ~~~~~ ^ Original issue's description: > Remove redundant 'derived constraint space' setters from NGConstraintSpace > > Remove > SetOverflowTriggersScrollbar > SetFixedSize > SetFragmentationType > SetIsNewFormattingContext > SetSize > Size > from NGConstraintSpace. Use NGConstraintSpaceBuilder instead. > > BUG=635619 > > Committed: https://crrev.com/2bd351a87b733b8b17f6507adb9b6d0829ca978f > Cr-Commit-Position: refs/heads/master@{#433404} TBR=ikilpatrick@chromium.org,cbiesinger@chromium.org,glebl@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619 Committed: https://crrev.com/fe55fbc67370abded2c79b78b2dad835345b0158 Cr-Commit-Position: refs/heads/master@{#433405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -11 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 3 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 3 chunks +42 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
sadrul
Created Revert of Remove redundant 'derived constraint space' setters from NGConstraintSpace
4 years, 1 month ago (2016-11-19 06:00:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514693004/1
4 years, 1 month ago (2016-11-19 06:00:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-19 06:01:19 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 06:02:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe55fbc67370abded2c79b78b2dad835345b0158
Cr-Commit-Position: refs/heads/master@{#433405}

Powered by Google App Engine
This is Rietveld 408576698