Field trial synchronization to PPAPI process.

Field trial synchronization to PPAPI process.

This enables the same field trial synchronization mechanism we use for
renderers and GPU process for the PPAPI process. With this CL, crash reports
from PPAPI process will include active field trials and field trials activated
in the PPAPI process will be reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
TEST=In an official Chrome build with crash reporting enabled, verify you have
Variations hashes listed in chrome://version (restart if you don't) and then go
to http://www.adobe.com/software/flash/about/ and load some flash content
before going to chrome://ppapiflashcrash to cause a PPAPI crash. Then, find the
the crash entry that should now appear on chrome://crashes and view it on
http://crash/ via the Server ID and check that the crash report has entries
under Experiments (under Fields).

Committed: https://crrev.com/92c1a939725f1108fe9dcca812d5e6a65defc24a
Cr-Commit-Position: refs/heads/master@{#434384}

[Alexei Svitkine (slow), 2016-11-17 22:45:47]

Description was changed from

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization
mechanism we use for renderers and GPU process for
the PPAPI process. With this CL, crash reports from
PPAPI process will include active field trials and
field trials activated in the PPAPI process will be
reported to UMA and crash.

To support this, moves ChildProcessFieldTrialSyncer
to components/variations so that PPAPI can depend on
it.

BUG=582602
==========

to

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization
mechanism we use for renderers and GPU process for
the PPAPI process. With this CL, crash reports from
PPAPI process will include active field trials and
field trials activated in the PPAPI process will be
reported to UMA and crash.

BUG=582602
==========

[Alexei Svitkine (slow), 2016-11-17 22:46:29]

Description was changed from

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization
mechanism we use for renderers and GPU process for
the PPAPI process. With this CL, crash reports from
PPAPI process will include active field trials and
field trials activated in the PPAPI process will be
reported to UMA and crash.

BUG=582602
==========

to

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization
mechanism we use for renderers and GPU process for
the PPAPI process. With this CL, crash reports from
PPAPI process will include active field trials and
field trials activated in the PPAPI process will be
reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components a long the way.

BUG=582602
==========

[Alexei Svitkine (slow), 2016-11-17 22:46:39]

Description was changed from

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization
mechanism we use for renderers and GPU process for
the PPAPI process. With this CL, crash reports from
PPAPI process will include active field trials and
field trials activated in the PPAPI process will be
reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components a long the way.

BUG=582602
==========

to

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization
mechanism we use for renderers and GPU process for
the PPAPI process. With this CL, crash reports from
PPAPI process will include active field trials and
field trials activated in the PPAPI process will be
reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
==========

[Alexei Svitkine (slow), 2016-11-17 22:48:44]

Patchset #1 (id:1) has been deleted

[Alexei Svitkine (slow), 2016-11-17 22:53:27]

asvitkine@chromium.org changed reviewers:
+ piman@chromium.org, wfh@chromium.org

[Alexei Svitkine (slow), 2016-11-17 22:53:27]

piman, wfh: PTAL

piman, the current CL is adding a dependency from content to variations 
component which I believe is likely not OK to content/ OWNERS (jam is away
but I suspect he would not want this dependency). I'm sending the CL in its
current form so we can discuss alternatives while having the context of
what I'm trying to do.

Basically, we need to create a FieldTrialSyncer object early during PPAPI
process lifetime. For renderer and GPU processes, this is handled by
Chrome-level delegate objects (ChromeRendererThreadObserver and
ChromeContentGpuClient), but PPAPI process doesn't appear to have a similar
object I can use.

We can either add one for PPAPI - which would exist solely to support this
functionality - or the other option is to add it to ContentClient API. If
it was part of ContentClient, we could implement it once in
ChromeContentClient and share code between renderer, gpu & ppapi processes.
To me, that sounds like the best approach - but it does require expanding
ContentClient API surface - what do you think?

(The reason we'd need a new API surface rather than everything being
contained in ChromeContentClient is because each process type uses distinct
IPC message types which can't be shared - so FieldTrialSyncer needs to
delegate to the actual process-specific code to send the appropriate
message to the process host object on the browser side.)

[piman, 2016-11-18 00:24:34]

LGTM from my side.

https://codereview.chromium.org/2514593002/diff/20001/content/ppapi_plugin/BU...
File content/ppapi_plugin/BUILD.gn (right):

https://codereview.chromium.org/2514593002/diff/20001/content/ppapi_plugin/BU...
content/ppapi_plugin/BUILD.gn:49: "//components/variations",
I think this is ok. content/browser already depends on //components/variations.

[Alexei Svitkine (slow), 2016-11-18 23:30:36]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 23:31:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2016-11-18 23:32:58]

asvitkine@chromium.org changed reviewers:
+ jochen@chromium.org, raymes@chromium.org

[Alexei Svitkine (slow), 2016-11-18 23:32:59]

+jochen for chrome/renderer OWNERS
+raymes for ppapi OWNERS

wfh - PTAL as well

[Alexei Svitkine (slow), 2016-11-18 23:34:30]

asvitkine@chromium.org changed reviewers:
- raymes@chromium.org

[Alexei Svitkine (slow), 2016-11-18 23:34:31]

Actually -raymes as I have PPAI review from piman already and I'm just missing
security review from wfh for the IPC messages.

[Will Harris, 2016-11-19 00:15:09]

This is cool. thanks for doing this. lgtm. Was there manual testing to verify
crashes actually contain field trials? Can this be automated at all?

[commit-bot: I haz the power, 2016-11-19 03:33:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 03:33:08]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-11-21 11:06:03]

lgtm

[Alexei Svitkine (slow), 2016-11-21 15:56:47]

On Fri, Nov 18, 2016 at 7:15 PM, <wfh@chromium.org> wrote:

> This is cool. thanks for doing this. lgtm. Was there manual testing to
> verify
> crashes actually contain field trials? Can this be automated at all?
>

I didn't verify actual crashes - but I did check that the codepaths were
being hit. Now that I look at chrome://chrome-urls - I guess I can trigger
a PPAPI flash via chrome://ppapiflashcrash? If so, I'll try that and make
sure it's working as expected.

Not sure of an automated way to test this. AFAIK, we don't have automated
tests for other subprocesses crash keys either.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Will Harris, 2016-11-21 17:39:36]

On 2016/11/21 15:56:47, Alexei Svitkine (slow) wrote:
> On Fri, Nov 18, 2016 at 7:15 PM, <mailto:wfh@chromium.org> wrote:
> 
> > This is cool. thanks for doing this. lgtm. Was there manual testing to
> > verify
> > crashes actually contain field trials? Can this be automated at all?
> >
> 
> I didn't verify actual crashes - but I did check that the codepaths were
> being hit. Now that I look at chrome://chrome-urls - I guess I can trigger
> a PPAPI flash via chrome://ppapiflashcrash? If so, I'll try that and make
> sure it's working as expected.
> 
> Not sure of an automated way to test this. AFAIK, we don't have automated
> tests for other subprocesses crash keys either.
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

if it's manual like chrome://ppapiflashcrash it would be good to put the manual
steps in a TEST= key so TE can verify it's working fine before we ship this.
Thanks.

[Alexei Svitkine (slow), 2016-11-21 20:54:30]

Thanks, will add the TEST= line after I confirm that it works - building an
official build for that so it can actually upload its crashes.

I'll also need to rebase this on top of
https://codereview.chromium.org/2504163005/ - which will require a small change
to this CL (since single process flag is not available from variations
component).

[Alexei Svitkine (slow), 2016-11-23 16:28:30]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 16:29:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 17:34:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 17:34:34]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2016-11-23 21:13:08]

Description was changed from

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization
mechanism we use for renderers and GPU process for
the PPAPI process. With this CL, crash reports from
PPAPI process will include active field trials and
field trials activated in the PPAPI process will be
reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
==========

to

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization
mechanism we use for renderers and GPU process for
the PPAPI process. With this CL, crash reports from
PPAPI process will include active field trials and
field trials activated in the PPAPI process will be
reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
TEST=In an official Chrome build with crash reporting enabled, verify you have
Variations hashes listed in chrome://version (restart if you don't) and then go
to chrome://ppapiflashcrash to cause a PPAPI crash. Then, go to chrome://crashes
and visit crash/<Server ID from chrome://crashes> and check that the crash
report has Experiments listed under Fields.)
==========

[Alexei Svitkine (slow), 2016-11-23 21:13:30]

Description was changed from

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization
mechanism we use for renderers and GPU process for
the PPAPI process. With this CL, crash reports from
PPAPI process will include active field trials and
field trials activated in the PPAPI process will be
reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
TEST=In an official Chrome build with crash reporting enabled, verify you have
Variations hashes listed in chrome://version (restart if you don't) and then go
to chrome://ppapiflashcrash to cause a PPAPI crash. Then, go to chrome://crashes
and visit crash/<Server ID from chrome://crashes> and check that the crash
report has Experiments listed under Fields.)
==========

to

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization
mechanism we use for renderers and GPU process for
the PPAPI process. With this CL, crash reports from
PPAPI process will include active field trials and
field trials activated in the PPAPI process will be
reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
TEST=In an official Chrome build with crash reporting enabled, verify you have
Variations hashes listed in chrome://version (restart if you don't) and then go
to
chrome://ppapiflashcrash to cause a PPAPI crash. Then, go to chrome://crashes
and visit crash/<Server ID from chrome://crashes> and check that the crash
report
has Experiments listed under Fields.
==========

[Alexei Svitkine (slow), 2016-11-23 21:14:39]

Description was changed from

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization
mechanism we use for renderers and GPU process for
the PPAPI process. With this CL, crash reports from
PPAPI process will include active field trials and
field trials activated in the PPAPI process will be
reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
TEST=In an official Chrome build with crash reporting enabled, verify you have
Variations hashes listed in chrome://version (restart if you don't) and then go
to
chrome://ppapiflashcrash to cause a PPAPI crash. Then, go to chrome://crashes
and visit crash/<Server ID from chrome://crashes> and check that the crash
report
has Experiments listed under Fields.
==========

to

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization mechanism we use for
renderers and GPU process for the PPAPI process. With this CL, crash reports
from PPAPI process will include active field trials and field trials activated
in the PPAPI process will be reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
TEST=In an official Chrome build with crash reporting enabled, verify you have
Variations hashes listed in chrome://version (restart if you don't) and then go
to chrome://ppapiflashcrash to cause a PPAPI crash. Then, go to chrome://crashes
and visit crash/<Server ID from chrome://crashes> and check that the crash
report has Experiments listed under Fields.
==========

[Alexei Svitkine (slow), 2016-11-23 21:34:31]

chrome://ppapiflashcrash seems to be broken on TOT/canary :(

(It works on stable Chrome though.)

So much for using that in my TEST= line.

Will try to bisect to figure out what broke it.

[Alexei Svitkine (slow), 2016-11-23 22:21:05]

Description was changed from

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization mechanism we use for
renderers and GPU process for the PPAPI process. With this CL, crash reports
from PPAPI process will include active field trials and field trials activated
in the PPAPI process will be reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
TEST=In an official Chrome build with crash reporting enabled, verify you have
Variations hashes listed in chrome://version (restart if you don't) and then go
to chrome://ppapiflashcrash to cause a PPAPI crash. Then, go to chrome://crashes
and visit crash/<Server ID from chrome://crashes> and check that the crash
report has Experiments listed under Fields.
==========

to

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization mechanism we use for
renderers and GPU process for the PPAPI process. With this CL, crash reports
from PPAPI process will include active field trials and field trials activated
in the PPAPI process will be reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
TEST=In an official Chrome build with crash reporting enabled, verify you have
Variations hashes listed in chrome://version (restart if you don't) and then go
to http://www.adobe.com/software/flash/about/ and load some flash content
before going to chrome://ppapiflashcrash to cause a PPAPI crash. Then, find the
the crash entry that should now appear on chrome://crashes and view it via
crash/<Server ID from chrome://crashes> and check that the crash report has
Experiments listed under Fields.
==========

[Alexei Svitkine (slow), 2016-11-23 22:21:40]

Description was changed from

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization mechanism we use for
renderers and GPU process for the PPAPI process. With this CL, crash reports
from PPAPI process will include active field trials and field trials activated
in the PPAPI process will be reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
TEST=In an official Chrome build with crash reporting enabled, verify you have
Variations hashes listed in chrome://version (restart if you don't) and then go
to http://www.adobe.com/software/flash/about/ and load some flash content
before going to chrome://ppapiflashcrash to cause a PPAPI crash. Then, find the
the crash entry that should now appear on chrome://crashes and view it via
crash/<Server ID from chrome://crashes> and check that the crash report has
Experiments listed under Fields.
==========

to

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization mechanism we use for
renderers and GPU process for the PPAPI process. With this CL, crash reports
from PPAPI process will include active field trials and field trials activated
in the PPAPI process will be reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
TEST=In an official Chrome build with crash reporting enabled, verify you have
Variations hashes listed in chrome://version (restart if you don't) and then go
to http://www.adobe.com/software/flash/about/ and load some flash content
before going to chrome://ppapiflashcrash to cause a PPAPI crash. Then, find the
the crash entry that should now appear on chrome://crashes and view it via
http://crash/<Server ID from chrome://crashes> and check that the crash report
has
Experiments listed under Fields.
==========

[Alexei Svitkine (slow), 2016-11-23 22:22:25]

Description was changed from

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization mechanism we use for
renderers and GPU process for the PPAPI process. With this CL, crash reports
from PPAPI process will include active field trials and field trials activated
in the PPAPI process will be reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
TEST=In an official Chrome build with crash reporting enabled, verify you have
Variations hashes listed in chrome://version (restart if you don't) and then go
to http://www.adobe.com/software/flash/about/ and load some flash content
before going to chrome://ppapiflashcrash to cause a PPAPI crash. Then, find the
the crash entry that should now appear on chrome://crashes and view it via
http://crash/<Server ID from chrome://crashes> and check that the crash report
has
Experiments listed under Fields.
==========

to

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization mechanism we use for
renderers and GPU process for the PPAPI process. With this CL, crash reports
from PPAPI process will include active field trials and field trials activated
in the PPAPI process will be reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
TEST=In an official Chrome build with crash reporting enabled, verify you have
Variations hashes listed in chrome://version (restart if you don't) and then go
to http://www.adobe.com/software/flash/about/ and load some flash content
before going to chrome://ppapiflashcrash to cause a PPAPI crash. Then, find the
the crash entry that should now appear on chrome://crashes and view it on
http://crash/ via the Server ID and check that the crash report has entries
under
Experiments (under Fields).
==========

[Alexei Svitkine (slow), 2016-11-23 22:22:52]

Description was changed from

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization mechanism we use for
renderers and GPU process for the PPAPI process. With this CL, crash reports
from PPAPI process will include active field trials and field trials activated
in the PPAPI process will be reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
TEST=In an official Chrome build with crash reporting enabled, verify you have
Variations hashes listed in chrome://version (restart if you don't) and then go
to http://www.adobe.com/software/flash/about/ and load some flash content
before going to chrome://ppapiflashcrash to cause a PPAPI crash. Then, find the
the crash entry that should now appear on chrome://crashes and view it on
http://crash/ via the Server ID and check that the crash report has entries
under
Experiments (under Fields).
==========

to

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization mechanism we use for
renderers and GPU process for the PPAPI process. With this CL, crash reports
from PPAPI process will include active field trials and field trials activated
in the PPAPI process will be reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
TEST=In an official Chrome build with crash reporting enabled, verify you have
Variations hashes listed in chrome://version (restart if you don't) and then go
to http://www.adobe.com/software/flash/about/ and load some flash content
before going to chrome://ppapiflashcrash to cause a PPAPI crash. Then, find the
the crash entry that should now appear on chrome://crashes and view it on
http://crash/ via the Server ID and check that the crash report has entries
under Experiments (under Fields).
==========

[Alexei Svitkine (slow), 2016-11-24 17:15:37]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 17:15:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2016-11-24 17:15:53]

Patchset #4 (id:80001) has been deleted

[Alexei Svitkine (slow), 2016-11-24 17:20:24]

In patch set 4:
  - Rebased on top of https://codereview.chromium.org/2525973003 and
https://codereview.chromium.org/2504163005/
  - Added TEST= line on how to manually verify this with
chrome://ppapiflashcrash (turns out that it is indeed working fine)
  - Added a missing step from earlier patchset of actually adding the relevant
flags to the process command line in ppapi_plugin_process_host.cc

Planning to land later today if there are no concerns.

[commit-bot: I haz the power, 2016-11-24 17:28:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 17:28:32]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Alexei Svitkine (slow), 2016-11-24 17:35:32]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 17:35:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 18:07:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 18:07:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexei Svitkine (slow), 2016-11-24 18:29:48]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-11-24 18:29:48]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org,
jochen@chromium.org, wfh@chromium.org
Link to the patchset: https://codereview.chromium.org/2514593002/#ps120001
(title: "Fix namespace.")

[commit-bot: I haz the power, 2016-11-24 18:30:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 19:51:25]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1480012188102130,
"parent_rev": "f046741bba1750ff45117d8b5f6697d5eeb02267", "commit_rev":
"c14358c1a47f7c924c1eaa5fbc8c07544365a7eb"}

[commit-bot: I haz the power, 2016-11-24 19:51:49]

Description was changed from

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization mechanism we use for
renderers and GPU process for the PPAPI process. With this CL, crash reports
from PPAPI process will include active field trials and field trials activated
in the PPAPI process will be reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
TEST=In an official Chrome build with crash reporting enabled, verify you have
Variations hashes listed in chrome://version (restart if you don't) and then go
to http://www.adobe.com/software/flash/about/ and load some flash content
before going to chrome://ppapiflashcrash to cause a PPAPI crash. Then, find the
the crash entry that should now appear on chrome://crashes and view it on
http://crash/ via the Server ID and check that the crash report has entries
under Experiments (under Fields).
==========

to

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization mechanism we use for
renderers and GPU process for the PPAPI process. With this CL, crash reports
from PPAPI process will include active field trials and field trials activated
in the PPAPI process will be reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
TEST=In an official Chrome build with crash reporting enabled, verify you have
Variations hashes listed in chrome://version (restart if you don't) and then go
to http://www.adobe.com/software/flash/about/ and load some flash content
before going to chrome://ppapiflashcrash to cause a PPAPI crash. Then, find the
the crash entry that should now appear on chrome://crashes and view it on
http://crash/ via the Server ID and check that the crash report has entries
under Experiments (under Fields).
==========

[commit-bot: I haz the power, 2016-11-24 19:51:51]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-11-24 19:55:34]

Description was changed from

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization mechanism we use for
renderers and GPU process for the PPAPI process. With this CL, crash reports
from PPAPI process will include active field trials and field trials activated
in the PPAPI process will be reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
TEST=In an official Chrome build with crash reporting enabled, verify you have
Variations hashes listed in chrome://version (restart if you don't) and then go
to http://www.adobe.com/software/flash/about/ and load some flash content
before going to chrome://ppapiflashcrash to cause a PPAPI crash. Then, find the
the crash entry that should now appear on chrome://crashes and view it on
http://crash/ via the Server ID and check that the crash report has entries
under Experiments (under Fields).
==========

to

==========
Field trial synchronization to PPAPI process.

This enables the same field trial synchronization mechanism we use for
renderers and GPU process for the PPAPI process. With this CL, crash reports
from PPAPI process will include active field trials and field trials activated
in the PPAPI process will be reported to UMA and crash.

Moves child_process_field_trial_syncer.cc from chrome
to components along the way.

BUG=582602
TEST=In an official Chrome build with crash reporting enabled, verify you have
Variations hashes listed in chrome://version (restart if you don't) and then go
to http://www.adobe.com/software/flash/about/ and load some flash content
before going to chrome://ppapiflashcrash to cause a PPAPI crash. Then, find the
the crash entry that should now appear on chrome://crashes and view it on
http://crash/ via the Server ID and check that the crash report has entries
under Experiments (under Fields).

Committed: https://crrev.com/92c1a939725f1108fe9dcca812d5e6a65defc24a
Cr-Commit-Position: refs/heads/master@{#434384}
==========

[commit-bot: I haz the power, 2016-11-24 19:55:36]

Patchset 5 (id:??) landed as
https://crrev.com/92c1a939725f1108fe9dcca812d5e6a65defc24a
Cr-Commit-Position: refs/heads/master@{#434384}