Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2525973003:
Fix field trial DCHECK when gpu process is in-process. (Closed)
|
Created:
4 years ago by Alexei Svitkine (slow) Modified:
4 years ago CC:
chromium-reviews, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix field trial DCHECK when gpu process is in-process.
The DCHECK was introduced by my CL here:
https://codereview.chromium.org/2504163005/
In fact, it caught the problem that we were running
the field trial syncer code even when the GPU process
was part of the browser process, which is unneeded.
This change fixes that by not running that code in
that case.
BUG=668217
Committed: https://crrev.com/cbe6717b654cfd51f6eec2e12b90a91eb5186775
Cr-Commit-Position: refs/heads/master@{#434286}
Patch Set 1 #
Messages
Total messages: 25 (15 generated)
Patchset #1 (id:1) has been deleted
asvitkine@chromium.org changed reviewers: + piman@chromium.org
asvitkine@chromium.org changed reviewers: + mariakhomenko@chromium.org
lgtm
piman +TBR to land this sooner to unbreak bots - please take a look when you have a chance!
Description was changed from ========== Fix field trial DCHECK when gpu process is in-process. The DCHECK was introduced by my CL here: https://codereview.chromium.org/2504163005/ In fact, it caught the problem that we were running the field trial syncer code even when the GPU process was part of the browser process, which is unneeded. This change fixes that by not running that code in that case. BUG=668217 ========== to ========== Fix field trial DCHECK when gpu process is in-process. The DCHECK was introduced by my CL here: https://codereview.chromium.org/2504163005/ In fact, it caught the problem that we were running the field trial syncer code even when the GPU process was part of the browser process, which is unneeded. This change fixes that by not running that code in that case. BUG=668217 TBR=piman@chromium.org ==========
The CQ bit was checked by asvitkine@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Description was changed from ========== Fix field trial DCHECK when gpu process is in-process. The DCHECK was introduced by my CL here: https://codereview.chromium.org/2504163005/ In fact, it caught the problem that we were running the field trial syncer code even when the GPU process was part of the browser process, which is unneeded. This change fixes that by not running that code in that case. BUG=668217 TBR=piman@chromium.org ========== to ========== Fix field trial DCHECK when gpu process is in-process. The DCHECK was introduced by my CL here: https://codereview.chromium.org/2504163005/ In fact, it caught the problem that we were running the field trial syncer code even when the GPU process was part of the browser process, which is unneeded. This change fixes that by not running that code in that case. BUG=668217 TBR=piman@chromium.org NOTRY=true ==========
The CQ bit was unchecked by asvitkine@chromium.org
The CQ bit was checked by asvitkine@chromium.org
Description was changed from ========== Fix field trial DCHECK when gpu process is in-process. The DCHECK was introduced by my CL here: https://codereview.chromium.org/2504163005/ In fact, it caught the problem that we were running the field trial syncer code even when the GPU process was part of the browser process, which is unneeded. This change fixes that by not running that code in that case. BUG=668217 TBR=piman@chromium.org NOTRY=true ========== to ========== Fix field trial DCHECK when gpu process is in-process. The DCHECK was introduced by my CL here: https://codereview.chromium.org/2504163005/ In fact, it caught the problem that we were running the field trial syncer code even when the GPU process was part of the browser process, which is unneeded. This change fixes that by not running that code in that case. BUG=668217 NOTRY=true ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix field trial DCHECK when gpu process is in-process. The DCHECK was introduced by my CL here: https://codereview.chromium.org/2504163005/ In fact, it caught the problem that we were running the field trial syncer code even when the GPU process was part of the browser process, which is unneeded. This change fixes that by not running that code in that case. BUG=668217 NOTRY=true ========== to ========== Fix field trial DCHECK when gpu process is in-process. The DCHECK was introduced by my CL here: https://codereview.chromium.org/2504163005/ In fact, it caught the problem that we were running the field trial syncer code even when the GPU process was part of the browser process, which is unneeded. This change fixes that by not running that code in that case. BUG=668217 ==========
The CQ bit was unchecked by asvitkine@chromium.org
The CQ bit was checked by asvitkine@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479942336313570,
"parent_rev": "95058070a2670aa09c71bc831c22e73ae2c4d0b2", "commit_rev":
"9feae9afda7fa2387afdf8853a69274493d31666"}
Message was sent while issue was closed.
Description was changed from ========== Fix field trial DCHECK when gpu process is in-process. The DCHECK was introduced by my CL here: https://codereview.chromium.org/2504163005/ In fact, it caught the problem that we were running the field trial syncer code even when the GPU process was part of the browser process, which is unneeded. This change fixes that by not running that code in that case. BUG=668217 ========== to ========== Fix field trial DCHECK when gpu process is in-process. The DCHECK was introduced by my CL here: https://codereview.chromium.org/2504163005/ In fact, it caught the problem that we were running the field trial syncer code even when the GPU process was part of the browser process, which is unneeded. This change fixes that by not running that code in that case. BUG=668217 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix field trial DCHECK when gpu process is in-process. The DCHECK was introduced by my CL here: https://codereview.chromium.org/2504163005/ In fact, it caught the problem that we were running the field trial syncer code even when the GPU process was part of the browser process, which is unneeded. This change fixes that by not running that code in that case. BUG=668217 ========== to ========== Fix field trial DCHECK when gpu process is in-process. The DCHECK was introduced by my CL here: https://codereview.chromium.org/2504163005/ In fact, it caught the problem that we were running the field trial syncer code even when the GPU process was part of the browser process, which is unneeded. This change fixes that by not running that code in that case. BUG=668217 Committed: https://crrev.com/cbe6717b654cfd51f6eec2e12b90a91eb5186775 Cr-Commit-Position: refs/heads/master@{#434286} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/cbe6717b654cfd51f6eec2e12b90a91eb5186775 Cr-Commit-Position: refs/heads/master@{#434286} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
