Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 2514453005: DOMMatrix: add missing propagation of exceptions. (Closed)

Created:
4 years, 1 month ago by sof
Modified:
4 years, 1 month ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DOMMatrix: add missing propagation of exceptions. R= BUG=659899, 388780 Committed: https://crrev.com/9abf853349f70169c17607444ae977aad3a73114 Cr-Commit-Position: refs/heads/master@{#433449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-multiply.html View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrix.cpp View 3 chunks +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
sof
please take a look.
4 years, 1 month ago (2016-11-19 12:32:15 UTC) #4
haraken
LGTM
4 years, 1 month ago (2016-11-20 01:18:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514453005/1
4 years, 1 month ago (2016-11-20 06:25:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-20 06:31:31 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-20 06:34:39 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9abf853349f70169c17607444ae977aad3a73114
Cr-Commit-Position: refs/heads/master@{#433449}

Powered by Google App Engine
This is Rietveld 408576698