Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp

Issue 2514453005: DOMMatrix: add missing propagation of exceptions. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/DOMMatrix.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp
diff --git a/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp b/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp
index 7c7f2ede94b480e8a5869fa9af2897653f5a6e82..a3cc1da8182c721b93b902f67c7778c802ccabcd 100644
--- a/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp
+++ b/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp
@@ -34,7 +34,7 @@ void setDictionaryMembers(DOMMatrixInit& other) {
}
String getErrorMessage(const char* a, const char* b) {
- return String::format("The '%s' property should eqaul the '%s' property.", a,
+ return String::format("The '%s' property should equal the '%s' property.", a,
b);
}
@@ -127,8 +127,10 @@ DOMMatrixReadOnly* DOMMatrixReadOnly::fromFloat64Array(
DOMMatrixReadOnly* DOMMatrixReadOnly::fromMatrix(
DOMMatrixInit& other,
ExceptionState& exceptionState) {
- if (!validateAndFixup(other, exceptionState))
+ if (!validateAndFixup(other, exceptionState)) {
+ DCHECK(exceptionState.hadException());
return nullptr;
+ }
if (other.is2D()) {
double args[] = {other.m11(), other.m12(), other.m21(),
« no previous file with comments | « third_party/WebKit/Source/core/dom/DOMMatrix.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698