[Predator] Monitor found_suspects, has_regression_range and found_components using ts_mon

appengine/findit/crash/monitoring.py

Index: appengine/findit/crash/monitoring.py
diff --git a/appengine/findit/crash/monitoring.py b/appengine/findit/crash/monitoring.py
new file mode 100644
index 0000000000000000000000000000000000000000..0cd441692a288945f9965b1d48f5a9ad8bc3ade0
--- /dev/null
+++ b/appengine/findit/crash/monitoring.py
@@ -0,0 +1,17 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import gae_ts_mon
+
+found_suspects = gae_ts_mon.CounterMetric(
+    'predator/found_suspects',
+    description='Predator detection of suspected cls of a crash.')

[wrengr, 2016/11/22 19:34:18]

I'm not sure what exactly ts_mon stores, but these descriptions aren't very
helpful/descriptive. In general (because I've noticed this elsewhere in the
code), rephrasing method/function/field/variable names into sentence format is
not proper documentation. Docstrings etc serve a different purpose and are
intended for a different audience than variable names are, so just reiterating
the variable name is unhelpful and in many cases misleading.

[Sharu Jiang, 2016/11/22 22:15:51]

You are right, I changed the description to be more descriptive.

+
+has_regression_range = gae_ts_mon.CounterMetric(
+    'predator/has_regression_range',
+    description='Predator detection of regression range of a crash.')
+
+found_components = gae_ts_mon.CounterMetric(
+    'predator/found_components',
+    description='Predator detection of suspected components of a crash')