appengine/findit/crash/monitoring.py - Issue 2514413003: [Predator] Monitor found_suspects, has_regression_range and found_components using ts_mon

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/crash/monitoring.py

Issue 2514413003: [Predator] Monitor found_suspects, has_regression_range and found_components using ts_mon (Closed)

Patch Set: Update names of metrics. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import gae_ts_mon

	6

	7 found_suspects = gae_ts_mon.CounterMetric(

	8 'predator/found_suspects',

	9 description='Predator detection of suspected cls of a crash.')
	wrengr 2016/11/22 19:34:18 I'm not sure what exactly ts_mon stores, but these I'm not sure what exactly ts_mon stores, but these descriptions aren't very helpful/descriptive. In general (because I've noticed this elsewhere in the code), rephrasing method/function/field/variable names into sentence format is not proper documentation. Docstrings etc serve a different purpose and are intended for a different audience than variable names are, so just reiterating the variable name is unhelpful and in many cases misleading. Sharu Jiang 2016/11/22 22:15:51 You are right, I changed the description to be mor Show quoted text On 2016/11/22 19:34:18, wrengr wrote: > I'm not sure what exactly ts_mon stores, but these descriptions aren't very > helpful/descriptive. In general (because I've noticed this elsewhere in the > code), rephrasing method/function/field/variable names into sentence format is > not proper documentation. Docstrings etc serve a different purpose and are > intended for a different audience than variable names are, so just reiterating > the variable name is unhelpful and in many cases misleading. You are right, I changed the description to be more descriptive.
	10

	11 has_regression_range = gae_ts_mon.CounterMetric(

	12 'predator/has_regression_range',

	13 description='Predator detection of regression range of a crash.')

	14

	15 found_components = gae_ts_mon.CounterMetric(

	16 'predator/found_components',

	17 description='Predator detection of suspected components of a crash')

OLD	NEW

« no previous file with comments | « appengine/findit/crash/crash_pipeline.py ('k') | appengine/findit/crash/test/crash_testcase.py » ('j') | no next file with comments »