Clean up GTK3 build flags.

Clean up GTK3 build flags.

Moves the global build flag from build/config/ui.gni to a separate file in a new "gtk" directory.

Create a virtual target to forward to the correct GTK implementation as needed.

Committed: https://crrev.com/cdf496ad123d8b43452d65a81f76cbd26d348ebf
Cr-Commit-Position: refs/heads/master@{#433644}

[brettw, 2016-11-21 15:54:51]

Fixes

[brettw, 2016-11-21 15:56:31]

brettw@chromium.org changed reviewers:
+ thomasanderson@google.com

[brettw, 2016-11-21 15:56:35]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 15:56:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom (Use chromium acct), 2016-11-21 16:47:56]

Thanks for all of the cleanups Brett.  All of this lgtm!

[brettw, 2016-11-21 17:11:31]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-11-21 17:11:35]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-11-21 17:11:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 20:00:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 20:00:38]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-11-21 20:10:10]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-11-21 20:11:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 20:58:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479759010880290,
"parent_rev": "2bdffbae7a4be5b7740d60707596426c05bc4d7f", "commit_rev":
"9a345bbfe9bf236af2a691d013a06740691a2dba"}

[commit-bot: I haz the power, 2016-11-21 20:59:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-21 21:04:01]

Description was changed from

==========
Clean up GTK3 build flags.

Moves the global build flag from build/config/ui.gni to a separate file in a new
"gtk" directory.

Create a virtual target to forward to the correct GTK implementation as needed.
==========

to

==========
Clean up GTK3 build flags.

Moves the global build flag from build/config/ui.gni to a separate file in a new
"gtk" directory.

Create a virtual target to forward to the correct GTK implementation as needed.

Committed: https://crrev.com/cdf496ad123d8b43452d65a81f76cbd26d348ebf
Cr-Commit-Position: refs/heads/master@{#433644}
==========

[commit-bot: I haz the power, 2016-11-21 21:04:03]

Patchset 2 (id:??) landed as
https://crrev.com/cdf496ad123d8b43452d65a81f76cbd26d348ebf
Cr-Commit-Position: refs/heads/master@{#433644}

[Corentin Wallez, 2016-11-21 21:52:51]

cwallez@chromium.org changed reviewers:
+ cwallez@chromium.org

[Corentin Wallez, 2016-11-21 21:52:52]

https://codereview.chromium.org/2514413002/diff/20001/build/config/linux/gtk2...
File build/config/linux/gtk2/BUILD.gn (left):

https://codereview.chromium.org/2514413002/diff/20001/build/config/linux/gtk2...
build/config/linux/gtk2/BUILD.gn:29:
"//gpu/gles2_conform_support:gles2_conform_test_windowless",
This causes a generate_build_files failure on the Linux GPU Builder. See
https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/...
Uploaded a CL to fix this: https://codereview.chromium.org/2516313003