Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2516313003: Allow GLES2 conform to use GTK2 (Closed)

Created:
4 years, 1 month ago by Corentin Wallez
Modified:
4 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow GLES2 conform to use GTK2 cdf496ad123d8b43452d65a81f76cbd26d348ebf breaks the generate_build_files of the GPU Linux builder that has a special flag enabling compilation of the gles2_conform tests. TBR=brettw@chromium.org Committed: https://crrev.com/420f6d042815895b95a5200edee2214e4eb9029f Cr-Commit-Position: refs/heads/master@{#433698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/config/linux/gtk2/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516313003/1
4 years, 1 month ago (2016-11-21 21:53:05 UTC) #2
brettw
lgtm
4 years, 1 month ago (2016-11-21 22:17:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 23:50:08 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 23:53:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/420f6d042815895b95a5200edee2214e4eb9029f
Cr-Commit-Position: refs/heads/master@{#433698}

Powered by Google App Engine
This is Rietveld 408576698