Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: components/reading_list/BUILD.gn

Issue 2514333003: Componentize Reading List (Closed)
Patch Set: fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/reading_list/BUILD.gn
diff --git a/ios/chrome/browser/reading_list/BUILD.gn b/components/reading_list/BUILD.gn
similarity index 67%
copy from ios/chrome/browser/reading_list/BUILD.gn
copy to components/reading_list/BUILD.gn
index b707a5c56383ec8c26e84242cdf18072c5edb2a6..b0c8abedc3853c6331d2ea75e9e640dfc5b5b690 100644
--- a/ios/chrome/browser/reading_list/BUILD.gn
+++ b/components/reading_list/BUILD.gn
@@ -6,18 +6,12 @@ source_set("reading_list") {
sources = [
"offline_url_utils.cc",
"offline_url_utils.h",
- "reading_list_download_service.cc",
- "reading_list_download_service.h",
- "reading_list_download_service_factory.cc",
- "reading_list_download_service_factory.h",
"reading_list_entry.cc",
"reading_list_entry.h",
"reading_list_model.cc",
"reading_list_model.h",
"reading_list_model_bridge_observer.h",
"reading_list_model_bridge_observer.mm",
- "reading_list_model_factory.cc",
- "reading_list_model_factory.h",
"reading_list_model_impl.cc",
"reading_list_model_impl.h",
"reading_list_model_observer.h",
@@ -27,10 +21,8 @@ source_set("reading_list") {
"reading_list_store.cc",
"reading_list_store.h",
"reading_list_store_delegate.h",
- "reading_list_web_state_observer.h",
- "reading_list_web_state_observer.mm",
- "url_downloader.cc",
- "url_downloader.h",
+ "reading_list_switches.cc",
+ "reading_list_switches.h",
]
deps = [
"//base",
@@ -38,18 +30,13 @@ source_set("reading_list") {
"//components/keyed_service/ios",
"//components/pref_registry",
"//components/prefs",
+ "//components/reading_list/proto",
sdefresne 2016/11/21 14:48:31 This should go to public_deps
Olivier 2016/11/21 15:46:40 Done.
"//components/sync",
"//components/sync/protocol",
- "//ios/chrome/browser",
- "//ios/chrome/browser/browser_state",
- "//ios/chrome/browser/reading_list/proto",
"//ios/web",
"//net",
"//url",
]
- public_deps = [
- "//ios/chrome/browser/dom_distiller",
- ]
}
source_set("unit_tests") {
@@ -59,17 +46,14 @@ source_set("unit_tests") {
"reading_list_entry_unittest.cc",
"reading_list_model_unittest.cc",
"reading_list_store_unittest.cc",
- "url_downloader_unittest.cc",
]
deps = [
":reading_list",
"//base",
"//base/test:test_support",
+ "//components/reading_list/proto",
sdefresne 2016/11/21 14:48:31 This is only required here if directly included by
Olivier 2016/11/21 15:46:40 Done.
"//components/sync:test_support_model",
"//components/sync/protocol",
- "//ios/chrome/browser",
- "//ios/chrome/browser/dom_distiller",
- "//ios/chrome/browser/reading_list/proto",
"//ios/web:test_support",
"//testing/gtest",
"//url",

Powered by Google App Engine
This is Rietveld 408576698