Chromium Code Reviews Chromium Code Reviews
Issue 2514333003:
Componentize Reading List (Closed)
| OLD | NEW |
|---|---|
| 1 # Copyright 2016 The Chromium Authors. All rights reserved. | 1 # Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 source_set("reading_list") { | 5 source_set("reading_list") { |
| 6 sources = [ | 6 sources = [ |
| 7 "offline_url_utils.cc", | 7 "offline_url_utils.cc", |
| 8 "offline_url_utils.h", | 8 "offline_url_utils.h", |
| 9 "reading_list_download_service.cc", | |
| 10 "reading_list_download_service.h", | |
| 11 "reading_list_download_service_factory.cc", | |
| 12 "reading_list_download_service_factory.h", | |
| 13 "reading_list_entry.cc", | 9 "reading_list_entry.cc", |
| 14 "reading_list_entry.h", | 10 "reading_list_entry.h", |
| 15 "reading_list_model.cc", | 11 "reading_list_model.cc", |
| 16 "reading_list_model.h", | 12 "reading_list_model.h", |
| 17 "reading_list_model_bridge_observer.h", | 13 "reading_list_model_bridge_observer.h", |
| 18 "reading_list_model_bridge_observer.mm", | 14 "reading_list_model_bridge_observer.mm", |
| 19 "reading_list_model_factory.cc", | |
| 20 "reading_list_model_factory.h", | |
| 21 "reading_list_model_impl.cc", | 15 "reading_list_model_impl.cc", |
| 22 "reading_list_model_impl.h", | 16 "reading_list_model_impl.h", |
| 23 "reading_list_model_observer.h", | 17 "reading_list_model_observer.h", |
| 24 "reading_list_model_storage.h", | 18 "reading_list_model_storage.h", |
| 25 "reading_list_pref_names.cc", | 19 "reading_list_pref_names.cc", |
| 26 "reading_list_pref_names.h", | 20 "reading_list_pref_names.h", |
| 27 "reading_list_store.cc", | 21 "reading_list_store.cc", |
| 28 "reading_list_store.h", | 22 "reading_list_store.h", |
| 29 "reading_list_store_delegate.h", | 23 "reading_list_store_delegate.h", |
| 30 "reading_list_web_state_observer.h", | 24 "reading_list_switches.cc", |
| 31 "reading_list_web_state_observer.mm", | 25 "reading_list_switches.h", |
| 32 "url_downloader.cc", | |
| 33 "url_downloader.h", | |
| 34 ] | 26 ] |
| 35 deps = [ | 27 deps = [ |
| 36 "//base", | 28 "//base", |
| 37 "//components/keyed_service/core", | 29 "//components/keyed_service/core", |
| 38 "//components/keyed_service/ios", | 30 "//components/keyed_service/ios", |
| 39 "//components/pref_registry", | 31 "//components/pref_registry", |
| 40 "//components/prefs", | 32 "//components/prefs", |
| 33 "//components/reading_list/proto", | |
|
sdefresne
2016/11/21 14:48:31
This should go to public_deps
Olivier
2016/11/21 15:46:40
Done.
| |
| 41 "//components/sync", | 34 "//components/sync", |
| 42 "//components/sync/protocol", | 35 "//components/sync/protocol", |
| 43 "//ios/chrome/browser", | |
| 44 "//ios/chrome/browser/browser_state", | |
| 45 "//ios/chrome/browser/reading_list/proto", | |
| 46 "//ios/web", | 36 "//ios/web", |
| 47 "//net", | 37 "//net", |
| 48 "//url", | 38 "//url", |
| 49 ] | 39 ] |
| 50 public_deps = [ | |
| 51 "//ios/chrome/browser/dom_distiller", | |
| 52 ] | |
| 53 } | 40 } |
| 54 | 41 |
| 55 source_set("unit_tests") { | 42 source_set("unit_tests") { |
| 56 testonly = true | 43 testonly = true |
| 57 sources = [ | 44 sources = [ |
| 58 "offline_url_utils_unittest.cc", | 45 "offline_url_utils_unittest.cc", |
| 59 "reading_list_entry_unittest.cc", | 46 "reading_list_entry_unittest.cc", |
| 60 "reading_list_model_unittest.cc", | 47 "reading_list_model_unittest.cc", |
| 61 "reading_list_store_unittest.cc", | 48 "reading_list_store_unittest.cc", |
| 62 "url_downloader_unittest.cc", | |
| 63 ] | 49 ] |
| 64 deps = [ | 50 deps = [ |
| 65 ":reading_list", | 51 ":reading_list", |
| 66 "//base", | 52 "//base", |
| 67 "//base/test:test_support", | 53 "//base/test:test_support", |
| 54 "//components/reading_list/proto", | |
|
sdefresne
2016/11/21 14:48:31
This is only required here if directly included by
Olivier
2016/11/21 15:46:40
Done.
| |
| 68 "//components/sync:test_support_model", | 55 "//components/sync:test_support_model", |
| 69 "//components/sync/protocol", | 56 "//components/sync/protocol", |
| 70 "//ios/chrome/browser", | |
| 71 "//ios/chrome/browser/dom_distiller", | |
| 72 "//ios/chrome/browser/reading_list/proto", | |
| 73 "//ios/web:test_support", | 57 "//ios/web:test_support", |
| 74 "//testing/gtest", | 58 "//testing/gtest", |
| 75 "//url", | 59 "//url", |
| 76 ] | 60 ] |
| 77 } | 61 } |
| OLD | NEW |
