Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2514323002: Show media album title in Quick View metadata box. (Closed)

Created:
4 years, 1 month ago by oka
Modified:
4 years, 1 month ago
Reviewers:
fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org, fukino
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show media album title in Quick View metadata box. TEST=TBD BUG=636191 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0ed90e08c3abb07ebae8858315d2a481d1fefdd8 Cr-Commit-Position: refs/heads/master@{#433515}

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1

Patch Set 3 : Fix the bug that it fails to display metadata; avoided to assign undefined to the metadata attribut… #

Patch Set 4 : Format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M ui/file_manager/file_manager/foreground/elements/files_metadata_box.html View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_metadata_box.js View 2 chunks +3 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js View 1 chunk +10 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata_box_controller.js View 1 2 3 2 chunks +12 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (11 generated)
oka
4 years, 1 month ago (2016-11-21 09:22:09 UTC) #2
fukino
lgtm with a nit. https://codereview.chromium.org/2514323002/diff/20001/ui/file_manager/file_manager/foreground/js/metadata_box_controller.js File ui/file_manager/file_manager/foreground/js/metadata_box_controller.js (right): https://codereview.chromium.org/2514323002/diff/20001/ui/file_manager/file_manager/foreground/js/metadata_box_controller.js#newcode142 ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:142: ['imageHeight', nit: Needs indent (like ...
4 years, 1 month ago (2016-11-21 09:31:28 UTC) #6
oscar.underground.oscar
On 2016/11/21 09:22:09, oka wrote: Very interesting case! From that point on, I would kindly ...
4 years, 1 month ago (2016-11-21 09:33:05 UTC) #7
oka
Format.
4 years, 1 month ago (2016-11-21 12:18:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514323002/60001
4 years, 1 month ago (2016-11-21 12:28:59 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-21 12:46:10 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 12:48:28 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0ed90e08c3abb07ebae8858315d2a481d1fefdd8
Cr-Commit-Position: refs/heads/master@{#433515}

Powered by Google App Engine
This is Rietveld 408576698