Check dimensions and content of bitmaps in EmbedderTests.

Check dimensions and content of bitmaps in EmbedderTests.

Committed: https://pdfium.googlesource.com/pdfium/+/bcd3e538f170a5ab2c3295f1a3b0062781d384a5

[Lei Zhang, 2016-11-19 08:44:15]

Patchset #1 (id:1) has been deleted

[Lei Zhang, 2016-11-19 08:44:21]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-19 08:44:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 08:47:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 08:47:37]

Dry run: Try jobs failed on following builders:
  linux on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux/builds/2862)
  linux_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_no_v8/bui...)

[Lei Zhang, 2016-11-19 08:58:55]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-19 08:58:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 09:03:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 09:03:29]

Dry run: Try jobs failed on following builders:
  linux on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux/builds/2863)
  linux_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)

[Lei Zhang, 2016-11-20 07:13:04]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-20 07:13:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-20 07:22:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-20 07:22:16]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-11-20 22:51:12]

thestig@chromium.org changed reviewers:
+ npm@chromium.org

[Lei Zhang, 2016-11-20 22:51:13]

PTAL and make sure it passes on your Mac locally. It passes locally on a Mac
here.

The md5 code is from Chromium's base/ but I'm not putting it in
third_party/base/ since it's for testing only.

[npm, 2016-11-21 16:15:18]

Unfortunately FPDFParserDecodeEmbeddertest.Bug_455199 failed:

Value of: pdfium::MD5String(FPDFBitmap_GetBuffer(bitmap), expected_stride *
expected_height)
  Actual: "b90475ca64d1348c3bf5e2b77ad9187a"
Expected: expected_md5sum
Which is: "538ccfbcf01eeec0e021049cc365f2f5"

https://codereview.chromium.org/2514173002/diff/40001/testing/utils/md5.cpp
File testing/utils/md5.cpp (right):

https://codereview.chromium.org/2514173002/diff/40001/testing/utils/md5.cpp#n...
testing/utils/md5.cpp:15: * except that you don't need to include two pages of
legalese
I thought this was you, but then I saw it was copy-pasted from base

[Tom Sepez, 2016-11-21 18:18:25]

tsepez@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-11-21 18:18:26]

https://codereview.chromium.org/2514173002/diff/40001/core/fpdfapi/page/fpdf_...
File core/fpdfapi/page/fpdf_page_func_embeddertest.cpp (right):

https://codereview.chromium.org/2514173002/diff/40001/core/fpdfapi/page/fpdf_...
core/fpdfapi/page/fpdf_page_func_embeddertest.cpp:18: CompareBitmap(bitmap, 612,
792, "1940568c9ba33bac5d0b1ee9558c76b3");
8 bytes is more than enough, probably don't need full 16 if you want to save
some digits.

https://codereview.chromium.org/2514173002/diff/40001/testing/utils/md5.cpp
File testing/utils/md5.cpp (right):

https://codereview.chromium.org/2514173002/diff/40001/testing/utils/md5.cpp#n...
testing/utils/md5.cpp:1: // Copyright 2016 PDFium Authors. All rights reserved.
We have an equivalent already in PDFium somewhere.  Maybe call it instead of
having to pull in the base code ...

https://codereview.chromium.org/2514173002/diff/40001/testing/utils/md5.h
File testing/utils/md5.h (right):

https://codereview.chromium.org/2514173002/diff/40001/testing/utils/md5.h#new...
testing/utils/md5.h:15: // MD5 is a robust hash function, designed for
cyptography, but often used
nit: s/is/was/ :).  Just give the link to wikipedia ...

[Tom Sepez, 2016-11-21 18:23:17]

https://codereview.chromium.org/2514173002/diff/40001/testing/utils/md5.cpp
File testing/utils/md5.cpp (right):

https://codereview.chromium.org/2514173002/diff/40001/testing/utils/md5.cpp#n...
testing/utils/md5.cpp:1: // Copyright 2016 PDFium Authors. All rights reserved.
On 2016/11/21 18:18:26, Tom Sepez wrote:
> We have an equivalent already in PDFium somewhere.  Maybe call it instead of
> having to pull in the base code ...

https://cs.chromium.org/chromium/src/third_party/pdfium/core/fdrm/crypto/fx_c...

In fact, if we were really on top of things, we'd pull the corresponding unit
test from base and run its cases against the FX implementation ...

[Tom Sepez, 2016-11-21 18:36:26]

> 
> In fact, if we were really on top of things, we'd pull the corresponding unit
> test from base and run its cases against the FX implementation ...
In fact, I'll take a quick stab at the unit test this morning.

[Tom Sepez, 2016-11-21 19:53:17]

On 2016/11/21 18:36:26, Tom Sepez wrote:
> > 
> > In fact, if we were really on top of things, we'd pull the corresponding
unit
> > test from base and run its cases against the FX implementation ...
> In fact, I'll take a quick stab at the unit test this morning.

https://codereview.chromium.org/2517153003/  says the FX impl is good.

[Lei Zhang, 2016-11-21 19:59:30]

OK, I'll get back to this in a bit and use the FX MD5 implementation.

I don't know what to do about the Mac rendering differences aside from passing
in a nullptr on Mac and skip the md5sum check. WDYT?

[Lei Zhang, 2016-11-21 20:27:34]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 20:27:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-11-21 20:28:13]

PTAL

[commit-bot: I haz the power, 2016-11-21 20:47:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 20:47:38]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-11-21 21:09:04]

lgtm

[Lei Zhang, 2016-11-21 21:37:07]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-11-21 21:37:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 21:37:29]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479764227373720,
"parent_rev": "d33c8e3145539631d03242a16c3683c3538c7557", "commit_rev":
"bcd3e538f170a5ab2c3295f1a3b0062781d384a5"}

[commit-bot: I haz the power, 2016-11-21 21:37:32]

Description was changed from

==========
Check dimensions and content of bitmaps in EmbedderTests.
==========

to

==========
Check dimensions and content of bitmaps in EmbedderTests.

Committed:
https://pdfium.googlesource.com/pdfium/+/bcd3e538f170a5ab2c3295f1a3b0062781d3...
==========

[commit-bot: I haz the power, 2016-11-21 21:37:33]

Committed patchset #3 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/bcd3e538f170a5ab2c3295f1a3b0062781d3...