Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2514123002: [Devtools] Moved NetworkWaterfallColumn to use NetworkLogEntry (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Moved NetworkWaterfallColumn to use NetworkLogEntry This patch is in prep to allow NetworkLogView/Columns to communicate in a multi-request manner for network groupping for the NetworkLogView. R=dgozman BUG=666971 Committed: https://crrev.com/c57a4062b232e2aa7a538d637b5f2000107e6c6d Cr-Commit-Position: refs/heads/master@{#433755}

Patch Set 1 #

Total comments: 1

Patch Set 2 : changes #

Total comments: 6

Patch Set 3 : changes #

Patch Set 4 : changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -94 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 1 2 4 chunks +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 1 2 3 4 chunks +14 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 1 2 4 chunks +16 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js View 1 2 18 chunks +55 lines, -61 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/ViewportDataGrid.js View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
allada
PTL
4 years, 1 month ago (2016-11-19 00:16:14 UTC) #1
dgozman
Pretty good, but let's use it in more places to be sure? https://codereview.chromium.org/2514123002/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js ...
4 years, 1 month ago (2016-11-21 19:45:05 UTC) #2
allada
PTL
4 years, 1 month ago (2016-11-21 23:23:46 UTC) #5
dgozman
lgtm https://codereview.chromium.org/2514123002/diff/60001/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js (right): https://codereview.chromium.org/2514123002/diff/60001/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js#newcode611 third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:611: Network.LogEntry = function() {}; I did like Network.NetworkLogEntry ...
4 years, 1 month ago (2016-11-21 23:31:27 UTC) #6
allada
done https://codereview.chromium.org/2514123002/diff/60001/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js (right): https://codereview.chromium.org/2514123002/diff/60001/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js#newcode611 third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:611: Network.LogEntry = function() {}; On 2016/11/21 23:31:26, dgozman ...
4 years, 1 month ago (2016-11-22 00:00:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514123002/100001
4 years, 1 month ago (2016-11-22 00:01:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/239115)
4 years, 1 month ago (2016-11-22 00:12:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514123002/100001
4 years, 1 month ago (2016-11-22 01:07:06 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:100001)
4 years, 1 month ago (2016-11-22 02:45:15 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 02:47:56 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c57a4062b232e2aa7a538d637b5f2000107e6c6d
Cr-Commit-Position: refs/heads/master@{#433755}

Powered by Google App Engine
This is Rietveld 408576698