[Devtools] Moved NetworkWaterfallColumn to use NetworkLogEntry

[Devtools] Moved NetworkWaterfallColumn to use NetworkLogEntry

This patch is in prep to allow NetworkLogView/Columns to communicate in
a multi-request manner for network groupping for the NetworkLogView.

R=dgozman
BUG=666971
Committed: https://crrev.com/c57a4062b232e2aa7a538d637b5f2000107e6c6d
Cr-Commit-Position: refs/heads/master@{#433755}

[allada, 2016-11-19 00:16:14]

PTL

[dgozman, 2016-11-21 19:45:05]

Pretty good, but let's use it in more places to be sure?

https://codereview.chromium.org/2514123002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2514123002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:605:
Network.NetworkLogEntry = class {
- @unrestricted
- I'd put this into a separate file.

[allada, 2016-11-21 23:20:38]

Patchset #2 (id:20001) has been deleted

[allada, 2016-11-21 23:20:43]

Patchset #2 (id:40001) has been deleted

[allada, 2016-11-21 23:23:46]

PTL

[dgozman, 2016-11-21 23:31:27]

lgtm

https://codereview.chromium.org/2514123002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2514123002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:611:
Network.LogEntry = function() {};
I did like Network.NetworkLogEntry more.

https://codereview.chromium.org/2514123002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2514123002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:784: *
@return {!Network.LogEntry}
Incorrect annotation.

https://codereview.chromium.org/2514123002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:786:
nodesList() {
flatNodesList to have the same name everywhere?

[allada, 2016-11-22 00:00:21]

done

https://codereview.chromium.org/2514123002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2514123002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:611:
Network.LogEntry = function() {};
On 2016/11/21 23:31:26, dgozman wrote:
> I did like Network.NetworkLogEntry more.

Done.

https://codereview.chromium.org/2514123002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2514123002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:784: *
@return {!Network.LogEntry}
On 2016/11/21 23:31:27, dgozman wrote:
> Incorrect annotation.

Done.

https://codereview.chromium.org/2514123002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:786:
nodesList() {
On 2016/11/21 23:31:27, dgozman wrote:
> flatNodesList to have the same name everywhere?

Done.

[allada, 2016-11-22 00:00:27]

The CQ bit was checked by allada@chromium.org

[allada, 2016-11-22 00:00:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2514123002/#ps100001
(title: "changes")

[commit-bot: I haz the power, 2016-11-22 00:01:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 00:12:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 00:12:58]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[allada, 2016-11-22 01:06:17]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2016-11-22 01:07:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 02:44:51]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1479776777754480,
"parent_rev": "e10010f86bfd3f1332202387559b5847d097c0c2", "commit_rev":
"c9a83f65d4c0383892a95ae31649842205fca704"}

[commit-bot: I haz the power, 2016-11-22 02:45:15]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-11-22 02:47:55]

Description was changed from

==========
[Devtools] Moved NetworkWaterfallColumn to use NetworkLogEntry

This patch is in prep to allow NetworkLogView/Columns to communicate in
a multi-request manner for network groupping for the NetworkLogView.

R=dgozman
BUG=666971
==========

to

==========
[Devtools] Moved NetworkWaterfallColumn to use NetworkLogEntry

This patch is in prep to allow NetworkLogView/Columns to communicate in
a multi-request manner for network groupping for the NetworkLogView.

R=dgozman
BUG=666971

Committed: https://crrev.com/c57a4062b232e2aa7a538d637b5f2000107e6c6d
Cr-Commit-Position: refs/heads/master@{#433755}
==========

[commit-bot: I haz the power, 2016-11-22 02:47:56]

Patchset 4 (id:??) landed as
https://crrev.com/c57a4062b232e2aa7a538d637b5f2000107e6c6d
Cr-Commit-Position: refs/heads/master@{#433755}