Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2514123002: [Devtools] Moved NetworkWaterfallColumn to use NetworkLogEntry (Closed)
Patch Set: changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
index ebf5b7a00da2f0f5e577d87cf1260f2e95df8e19..ab943236014e4742f731770c9359d4847986de92 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
@@ -29,6 +29,7 @@
*/
/**
+ * @implements {Network.NetworkLogEntry}
* @unrestricted
*/
Network.NetworkDataGridNode = class extends UI.SortableDataGridNode {
@@ -259,6 +260,7 @@ Network.NetworkDataGridNode = class extends UI.SortableDataGridNode {
}
/**
+ * @override
* @return {!SDK.NetworkRequest}
*/
request() {
@@ -266,6 +268,7 @@ Network.NetworkDataGridNode = class extends UI.SortableDataGridNode {
}
/**
+ * @override
* @return {boolean}
*/
isNavigationRequest() {
@@ -601,3 +604,20 @@ Network.NetworkDataGridNode = class extends UI.SortableDataGridNode {
cellElement.appendChild(subtitleElement);
}
};
+
+/**
+ * @interface
+ */
+Network.NetworkLogEntry = function() {};
+
+Network.NetworkLogEntry.prototype = {
+ /**
+ * @return {!SDK.NetworkRequest}
+ */
+ request() {},
+
+ /**
+ * @return {boolean}
+ */
+ isNavigationRequest() {}
+};
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698