Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1300)

Unified Diff: mojo/edk/test/run_all_unittests.cc

Issue 2514093002: Mojo EDK: Clean shutdown for ScopedIPCSupport in tests (Closed)
Patch Set: table flip emoji Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_mojo_bootstrap_unittest.cc ('k') | mojo/edk/test/scoped_ipc_support.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/test/run_all_unittests.cc
diff --git a/mojo/edk/test/run_all_unittests.cc b/mojo/edk/test/run_all_unittests.cc
index 05aed913a4868f2fa2ae443e1c9098a44ab23ade..cd6b241d605b05c6b8982303a3fa8e8a51ddaff3 100644
--- a/mojo/edk/test/run_all_unittests.cc
+++ b/mojo/edk/test/run_all_unittests.cc
@@ -43,11 +43,8 @@ int main(int argc, char** argv) {
mojo::test::TestSupport::Init(new mojo::edk::test::TestSupportImpl());
base::TestIOThread test_io_thread(base::TestIOThread::kAutoStart);
- // Leak this because its destructor calls mojo::edk::ShutdownIPCSupport which
- // really does nothing in the new EDK but does depend on the current message
- // loop, which is destructed inside base::LaunchUnitTests.
- new mojo::edk::test::ScopedIPCSupport(test_io_thread.task_runner());
+ mojo::edk::test::ScopedIPCSupport ipc_support(test_io_thread.task_runner());
return base::LaunchUnitTests(
argc, argv,
base::Bind(&base::TestSuite::Run, base::Unretained(&test_suite)));
« no previous file with comments | « ipc/ipc_mojo_bootstrap_unittest.cc ('k') | mojo/edk/test/scoped_ipc_support.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698