Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: mojo/edk/test/run_all_unittests.cc

Issue 2514093002: Mojo EDK: Clean shutdown for ScopedIPCSupport in tests (Closed)
Patch Set: table flip emoji Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ipc/ipc_mojo_bootstrap_unittest.cc ('k') | mojo/edk/test/scoped_ipc_support.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <signal.h> 5 #include <signal.h>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/test/launcher/unit_test_launcher.h" 9 #include "base/test/launcher/unit_test_launcher.h"
10 #include "base/test/multiprocess_test.h" 10 #include "base/test/multiprocess_test.h"
(...skipping 25 matching lines...) Expand all
36 // Removing the signal handler solves this issue. 36 // Removing the signal handler solves this issue.
37 signal(SIGABRT, SIG_DFL); 37 signal(SIGABRT, SIG_DFL);
38 #endif 38 #endif
39 39
40 base::TestSuite test_suite(argc, argv); 40 base::TestSuite test_suite(argc, argv);
41 41
42 mojo::edk::Init(); 42 mojo::edk::Init();
43 43
44 mojo::test::TestSupport::Init(new mojo::edk::test::TestSupportImpl()); 44 mojo::test::TestSupport::Init(new mojo::edk::test::TestSupportImpl());
45 base::TestIOThread test_io_thread(base::TestIOThread::kAutoStart); 45 base::TestIOThread test_io_thread(base::TestIOThread::kAutoStart);
46 // Leak this because its destructor calls mojo::edk::ShutdownIPCSupport which
47 // really does nothing in the new EDK but does depend on the current message
48 // loop, which is destructed inside base::LaunchUnitTests.
49 new mojo::edk::test::ScopedIPCSupport(test_io_thread.task_runner());
50 46
47 mojo::edk::test::ScopedIPCSupport ipc_support(test_io_thread.task_runner());
51 return base::LaunchUnitTests( 48 return base::LaunchUnitTests(
52 argc, argv, 49 argc, argv,
53 base::Bind(&base::TestSuite::Run, base::Unretained(&test_suite))); 50 base::Bind(&base::TestSuite::Run, base::Unretained(&test_suite)));
54 } 51 }
OLDNEW
« no previous file with comments | « ipc/ipc_mojo_bootstrap_unittest.cc ('k') | mojo/edk/test/scoped_ipc_support.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698